[Bug 203531] makefs causes ISO 9660 flaws in FreeBSD-11.0-CURRENT-amd64-*-disc1.iso
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Tue Oct 20 07:22:06 UTC 2015
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203531
--- Comment #1 from scdbackup at gmx.net ---
All four problems are present in NetBSD's makefs, too.
===================================================================
Problem 1:
Uninitialized malloc memory in timestamp of root directory.
http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.sbin/makefs/cd9660.c?annotate=1.49
The function cd9660_populate_iso_dir_record (line 733)
looks exactly like in FreeBSD.
cd9660_setup_root_node() does not set a date, whereas
cd9660_translate_node_common() does.
===================================================================
Problem 2:
Timestamp of "/bin" differs from timestamp of "/bin/."
http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.sbin/makefs/cd9660/iso9660_rrip.c?annotate=1.11.2.2
380: if (node->type & CD9660_TYPE_DOT) {
... no TF ...
397: } else if (node->type & CD9660_TYPE_DOTDOT) {
... no TF ...
413: } else {
414: cd9660_rrip_initialize_inode(node);
===================================================================
Problem 3:
Rock Ridge timestamp entry TF shows atime as Creation Time and
ctime as Access Time.
http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.sbin/makefs/cd9660/iso9660_rrip.h?annotate=1.5.8.1
51: #define TF_CREATION 0x00
52: #define TF_MODIFY 0x01
53: #define TF_ACCESS 0x02
54: #define TF_ATTRIBUTES 0x04
http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.sbin/makefs/cd9660/iso9660_rrip.c?annotate=1.11.2.2
690: p->attr.rr_entry.TF.flags[0] = TF_MODIFY | TF_ACCESS |
TF_ATTRIBUTES;
...
700: _node->inode->st.st_atime);
...
704: _node->inode->st.st_mtime);
...
708: _node->inode->st.st_ctime);
===================================================================
Problem 4:
Directories with all uppercase names get shown as lowercase
on Linux.
http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.sbin/makefs/cd9660/iso9660_rrip.c?annotate=1.11.2.2
417: * Not every node needs a NM set - only if the name is
418: * actually different. IE: If a file is TEST -> TEST,
419: * no NM. test -> TEST, need a NM
===================================================================
--
You are receiving this mail because:
You are the assignee for the bug.
More information about the freebsd-bugs
mailing list