[Bug 194483] [PATCH] libfetch: Properly deal with multi-line proxy responses to CONNECT requests

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194483

Dag-Erling Smørgrav <des at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #148498|0                           |1
        is obsolete|                            |
           Assignee|freebsd-bugs at FreeBSD.org    |des at FreeBSD.org
             Status|New                         |In Progress

--- Comment #1 from Dag-Erling Smørgrav <des at FreeBSD.org> ---
Created attachment 162043
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=162043&action=edit
Revised patch

Hi Fabian,

First, my apologies for not picking this up earlier.  It was not assigned to
me, and your cc: drowned in my inbox.

For the record, this bug is trivial to reproduce:

$ sudo pkg install privoxy
$ privoxy /dev/null
$ HTTP_PROXY=http://localhost:8118/ fetch -o/dev/null -v
https://www.freebsd.org/ 

I have prepared a different patch that uses http_next_header() to iterate over
the response instead of just reading until the buffer is empty (partly for
cleanliness and partly because I was unable to convince myself that this would
always work correctly).  Could you please confirm that it works for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.