[Bug 201664] [build] cannot build 'sort' using WITH_SORT_THREADS=yes

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201664

            Bug ID: 201664
           Summary: [build] cannot build 'sort' using
                    WITH_SORT_THREADS=yes
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: accornehl at fastmail.fm
                CC: gcooper at FreeBSD.org, markj at FreeBSD.org

I hit this error using a -CURRENT checkout from today. All that's needed to
reproduce this is building usr.bin/sort with "WITH_SORT_THREADS=yes" in the
environment or /etc/src.conf

# clang -v
FreeBSD clang version 3.6.0 (tags/RELEASE_360/final 230434) 20150225
Target: x86_64-unknown-freebsd11.0
Thread model: posix

--- radixsort.o ---
cc  -O2 -pipe   -DSORT_THREADS -g -std=gnu99 -fstack-protector -Wsystem-headers
-Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes
-Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings
-Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline
-Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign
-Wmissing-variable-declarations -Wthread-safety -Wno-empty-body
-Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments -c
/usr/home/acornehl/git/freebsd/usr.bin/sort/radixsort.c -o radixsort.o
/usr/home/acornehl/git/freebsd/usr.bin/sort/radixsort.c:144:17: error: mutex
'g_ls_mutex' is not held on every path through here
[-Werror,-Wthread-safety-analysis]
        new_ls->next = g_ls;
                       ^
/usr/home/acornehl/git/freebsd/usr.bin/sort/radixsort.c:141:3: note: mutex
acquired here
                pthread_mutex_lock(&g_ls_mutex);
                ^
/usr/home/acornehl/git/freebsd/usr.bin/sort/radixsort.c:149:3: error: releasing
mutex 'g_ls_mutex' that was not held [-Werror,-Wthread-safety-analysis]
                pthread_mutex_unlock(&g_ls_mutex);
                ^
2 errors generated.
*** [radixsort.o] Error code 1

make[4]: stopped in /usr/home/acornehl/git/freebsd/usr.bin/sort
1 error

-- 
You are receiving this mail because:
You are the assignee for the bug.