[Bug 196474] jls causes kernel panic

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196474

Mateusz Guzik <mjg at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjg at FreeBSD.org

--- Comment #6 from Mateusz Guzik <mjg at FreeBSD.org> ---
So in this case we have:
        error = vfs_setopt_part(opts, "ip4.addr", pr->pr_ip4,
            pr->pr_ip4s * sizeof(*pr->pr_ip4));

where pr_ip4s is -1.

I disagree with the patch.

First off, the bug is in the caller. If anything, bcopy could assert the size
to be positive. Unfortunately it is a md code so the check would have to be
replicated.

Proper fix would return an empty ip table (or no table), but no error.

-- 
You are receiving this mail because:
You are the assignee for the bug.