[Bug 205424] i386/boot: use macros from <machine/psl.h> to represent eflags's bits

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Dec 21 22:32:25 UTC 2015


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205424

John Baldwin <jhb at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|freebsd-bugs at FreeBSD.org    |jhb at FreeBSD.org
             Status|New                         |In Progress

--- Comment #1 from John Baldwin <jhb at FreeBSD.org> ---
The patch appears to have a lot of unrelated whitespace diffs.  Most of the
i386 boot code already uses PSL_* constants via the nested include of
<machine/psl.h> in btxv86.h.  In general the boot code uses V86_CY() to check
the carry flag and it looks like a few places just weren't updated to use that.

I've uploaded a change that I think fixes all the stragglers.  I haven't built
it yet to test though.

https://github.com/bsdjhb/freebsd/compare/boot_i386_eflags.diff

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list