[Bug 204943] usr/src/sbin/newfs_msdos/mkfs_msdos.c:586: memory leak ?

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204943

--- Comment #4 from David Binderman <dcb314 at hotmail.com> ---
>Although this fix is not wrong as such, fixing the memory leak in this >extremely rare error case does not make much sense if the happy path and error >cases that may actually happen still leak the memory.

True, but if there were leaks on the main path, I'd have reported
them before a leak on an error path.

More detail:

$ ~/cppcheck/trunk/cppcheck --enable=all usr/src/sbin/newfs_msdos/mkfs_msdos.c
Checking usr/src/sbin/newfs_msdos/mkfs_msdos.c...
[usr/src/sbin/newfs_msdos/mkfs_msdos.c:586]: (error) Memory leak: img
$ 

I see no evidence of any other memory leaks, or any other detectable problems,
in the source code file.

A patch for the leak has been produced, problem closed AFAIK.

-- 
You are receiving this mail because:
You are the assignee for the bug.