[Bug 204943] usr/src/sbin/newfs_msdos/mkfs_msdos.c:586: memory leak ?

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204943

Jilles Tjoelker <jilles at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jilles at FreeBSD.org

--- Comment #2 from Jilles Tjoelker <jilles at FreeBSD.org> ---
Although this fix is not wrong as such, fixing the memory leak in this
extremely rare error case does not make much sense if the happy path and error
cases that may actually happen still leak the memory. Note that this memory
leak is only a problem if the code in newfs_msdos.c is changed so it does not
exit immediately after mkfs_msdos() returns, or for static analyzers.

The error from sigaction() could also be ignored (silently or loudly), reducing
the code size, since a SIGINFO handler is not strictly required for creating a
filesystem.

-- 
You are receiving this mail because:
You are the assignee for the bug.