[Bug 202295] usr/src/sbin/ipfw/dummynet.c:1306: bad if test ?

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Thu Aug 13 16:10:04 UTC 2015


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202295

            Bug ID: 202295
           Summary: usr/src/sbin/ipfw/dummynet.c:1306: bad if test ?
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: misc
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: dcb314 at hotmail.com

[usr/src/sbin/ipfw/dummynet.c:1306]: (style) Same expression on both sides of
'||'.

Source code is

        if (v[1] < v[0] ||
            v[1] >= DN_MAX_ID-1 ||
            v[1] >= DN_MAX_ID-1) {
            continue; /* invalid entry */

Maybe

        if (v[1] < v[0] ||
            v[0] >= DN_MAX_ID-1 ||
            v[1] >= DN_MAX_ID-1) {
            continue; /* invalid entry */

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list