[Bug 193803] zvol rename failing due to out of order locking

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Oct 3 14:49:57 UTC 2014


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193803

--- Comment #32 from commit-hook at freebsd.org ---
A commit references this bug:

Author: smh
Date: Fri Oct  3 14:49:50 UTC 2014
New revision: 272474
URL: https://svnweb.freebsd.org/changeset/base/272474

Log:
  Fix various issues with zvols

  When performing snapshot renames we could deadlock due to the locking
  in zvol_rename_minors. In order to avoid this use the same workaround
  as zvol_open in zvol_rename_minors.

  Add missing zvol_rename_minors to dsl_dataset_promote_sync.

  Protect against invalid index into zv_name in zvol_remove_minors.

  Replace zvol_remove_minor calls with zvol_remove_minors to ensure
  any potential children are also renamed.

  Don't fail zvol_create_minors if zvol_create_minor returns EEXIST.

  Restore the valid pool check in zfs_ioc_destroy_snaps to ensure we
  don't call zvol_remove_minors when zfs_unmount_snap fails.

  PR:        193803
  MFC after:    1 week
  Sponsored by:    Multiplay

Changes:
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zvol.c

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list