[Bug 193367] [panic] sleeping thread

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Nov 28 11:35:07 UTC 2014


--- Comment #14 from Konstantin Belousov <kib at FreeBSD.org> ---
(In reply to Eygene Ryabinkin from comment #13)
> Perhaps the more proper thing will be to say
> .max_ioctl	= (DRM_ARRAY_SIZE(i915_ioctls) - 1)
> since this will preserve the semantics of the "max_ioctl" name that should
> keep the index of the last ioctl and not the number of driver-specific
> ioctls.
> I'd go this route, though the change will be slightly more intrusive; namely
> http://codelabs.ru/fbsd/patches/drm2/fix-drm_drv-off-by-one-v2.diff.
> What do you think?

I think that the original one-liner is fine, and this one is overcomplication.

You are receiving this mail because:
You are the assignee for the bug.

More information about the freebsd-bugs mailing list