[Bug 195010] New: sh1 authentication has problem with byte order assumption

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195010

            Bug ID: 195010
           Summary: sh1 authentication has problem with byte order
                    assumption
           Product: Base System
           Version: 9.1-RELEASE
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: hsuenju_ko at stratus.com

sys/crypto/sha1.c is missing the include file of sys/endian.h so the check like
the following won't work. And since unsupported is not defined any check of
BYTE_ORDR following this always evaluate to true. See sha1_step and sha1_result
for the reference of BYTE_ORDER. Problem occurs when communicating to non-BSD
system. 

/* sanity check */
#if BYTE_ORDER != BIG_ENDIAN
# if BYTE_ORDER != LITTLE_ENDIAN
#  define unsupported 1
# endif
#endif

-- 
You are receiving this mail because:
You are the assignee for the bug.