[Bug 90114] [patch] pw(8) takes strings after option -g for GID 0

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Tue Nov 4 07:51:47 UTC 2014


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=90114

--- Comment #2 from commit-hook at freebsd.org ---
A commit references this bug:

Author: bapt
Date: Tue Nov  4 07:50:51 UTC 2014
New revision: 274082
URL: https://svnweb.freebsd.org/changeset/base/274082

Log:
  MFC: 272445,272578,273772,273779,273782,273786,273787,273791

  Add a test for bug 191427 where pw(8) will go into an infinite loop
  Add some tests for modifying groups
  When a group is renamed then the group has been invalidated for sure.
  In that case get the group information using the new name.

  Fix a regression in pw usermod -G list

  The user was perperly adding the to different groups from "list" but was not
  removed from the other groups it could have belong to.

  Do not delete the group wheel when bad argument is passed to pw groupdel -g

  Check that the -g argument is actually a number, if not report an error.
  This argument is converted without checking with atoi(3) later so without
this
  check it converts any alpha entries into 0 meaning it deletes the group wheel

  Ensure pw userdel -u <invalid> do not try to remove root

  Check the uid passed is actually a number as early as possible

  Fix renaming a group via the gr_copy function

  Add a regression test to pw(8) because the bug was discovered via using:
  pw groupmod

  PR:        193704 [1], 185666 [2], 90114 [3], 187189 [4]
  Submitted by:    Marc de la Gueronniere [4]
  Reported by:    az [1], sub.mesa at gmail.com [2], bkoenig at cs.tu-berlin.de [3],
          mcdouga9 at egr.msu.edu [4]

Changes:
_U  stable/10/
  stable/10/etc/mtree/BSD.tests.dist
  stable/10/lib/libutil/gr_util.c
  stable/10/usr.sbin/pw/Makefile
  stable/10/usr.sbin/pw/pw_group.c
  stable/10/usr.sbin/pw/pw_user.c
  stable/10/usr.sbin/pw/tests/
  stable/10/usr.sbin/pw/tests/Makefile
  stable/10/usr.sbin/pw/tests/pw_delete.sh
  stable/10/usr.sbin/pw/tests/pw_modify.sh

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list