[Bug 192108] New: [patch] sed(1) bug in "addr1,+N" ranges

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Jul 25 09:48:39 UTC 2014


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192108

            Bug ID: 192108
           Summary: [patch] sed(1) bug in "addr1,+N" ranges
           Product: Base System
           Version: 9.2-STABLE
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Severity: Affects Some People
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: cejkar at fit.vutbr.cz

Created attachment 144962
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=144962&action=edit
Proposed patch for review

There is a bug in "addr1,+N" ranges in the case of last input line, let's try:

# seq 1 4 | sed -ne '1,+0p'
1
# seq 1 4 | sed -ne '1,+1p'
1
2
# seq 1 4 | sed -ne '1,+2p'
1
2
3
4                               <--- This line should not be printed!!!
# seq 1 4 | sed -ne '1,+3p'
1
2
3
4

The reason is that in case of AT_RELLINE, lastline()'s TRUE in MATCH() is taken
before the test for relative range next (process.c:291-297):

                        ...
                        if (MATCH(cp->a2)) {
                                cp->startline = 0;
                                lastaddr = 1;
                                r = 1;
                        } else if (linenum - cp->startline <= cp->a2->u.l)
                                r = 1;
                        else if ((cp->a2->type == AT_LINE &&
                        ...

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list