[Bug 191953] [vfs] [patch] better KASSERT msg in _vn_lock()

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191953

Hiren Panchasara <hiren at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hiren at FreeBSD.org

--- Comment #2 from Hiren Panchasara <hiren at FreeBSD.org> ---
Thanks for your submission. 

I am assuming that the comment is correct but the KASSERT itself is wrong. We
probably want to fail when either of the events fail. 

I am proposing following change to KASSERT. While here, fixing 80-column
wrapping.

-               KASSERT((flags & LK_RETRY) == 0 || error == 0,
-                   ("LK_RETRY set with incompatible flags (0x%x) or an error
occured (%d)",
-                   flags, error));
+               KASSERT((flags & LK_RETRY) == 0 && error == 0,
+                   ("LK_RETRY set with incompatible flags (0x%x) or an error "
+                   "occured (%d)", flags, error));

-- 
You are receiving this mail because:
You are the assignee for the bug.