[Bug 191884] [PATCH] teach chown and chmod about SIGINFO

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Tue Jul 15 19:37:36 UTC 2014


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191884

Mateusz Guzik <mjg at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjg at FreeBSD.org

--- Comment #1 from Mateusz Guzik <mjg at FreeBSD.org> ---
I have only small nits to add.

for both tools:
- no signal.h included
- manual pages not updated to reflect new functionality

chown:
- if (vflag) { verbose(p, vflag); } should loose braces
- 'verbose' is not the best name, maybe 'print_info'?

Patches for both utils should be attached separately.

Care to plug these problems?

Other than that looks good to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list