misc/186821: dtrace_dof_init() crashes when there is no probes section

[Fedor Indutny]

The following reply was made to PR misc/186821; it has been noted by GNATS.

From: Fedor Indutny <fedor at indutny.com>
To: bug-followup at freebsd.org, fedor at indutny.com
Cc:  
Subject: Re: misc/186821: dtrace_dof_init() crashes when there is no probes section
Date: Thu, 20 Feb 2014 16:10:27 +0400

 --089e0153673e53437b04f2d565b7
 Content-Type: text/plain; charset=ISO-8859-1
 
 Sorry, initial version of patch was very superficial. And it was only
 covering the actual problem, submitting proper patch as an attachment
 here.
 
 --089e0153673e53437b04f2d565b7
 Content-Type: application/octet-stream; name="proper-drti.patch"
 Content-Disposition: attachment; filename="proper-drti.patch"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_hrvzmzvo0
 
 Y29tbWl0IGM0Njc4NmY0NzQ4M2U3ZmMyMTg3MjdhYTUyY2Y2YjIyNzhhNDUwNTMKQXV0aG9yOiBG
 ZWRvciBJbmR1dG55IDxmZWRvci5pbmR1dG55QGdtYWlsLmNvbT4KRGF0ZTogICBNb24gRmViIDE3
 IDAxOjE2OjEzIDIwMTQgKzA0MDAKCiAgICBkdHJhY2U6IHByb3BlciBzeW1ib2wgZml4dXAgYW5k
 IGltcG9ydCBpbiBkcnRpCiAgICAKICAgIEFwcGxpY2F0aW9uIG1heSBjb250YWluIG11bHRpcGxl
 IERPRnMsIG1lcmdlZCBpbnRvIG9uZSAuX1NVTldfZG9mIEVMRgogICAgc2VjdGlvbi4gUHJvY2Vz
 cyBhbGwgb2YgdGhlbSBhbmQgZml4IHN5bWJvbHMgb25seSBpbiB0aG9zZSBvbmVzIHRoYXQKICAg
 IGFjdGF1bGx5IGRlZmluZSBhIHByb3ZpZGVyLiBVc2UgcHJvcGVyIHN0cnRhYiBmb3IgcmVzb2x2
 aW5nIHN5bWJvbHMuCgpkaWZmIC0tZ2l0IGEvY2RkbC9jb250cmliL29wZW5zb2xhcmlzL2xpYi9s
 aWJkdHJhY2UvY29tbW9uL2RydGkuYyBiL2NkZGwvY29udHJpYi9vcGVuc29sYXJpcy9saWIvbGli
 ZHRyYWNlL2NvbW1vbi9kcnRpLmMKaW5kZXggM2I0YTM4Yy4uZTQ3Y2ZiNGQgMTAwNjQ0Ci0tLSBh
 L2NkZGwvY29udHJpYi9vcGVuc29sYXJpcy9saWIvbGliZHRyYWNlL2NvbW1vbi9kcnRpLmMKKysr
 IGIvY2RkbC9jb250cmliL29wZW5zb2xhcmlzL2xpYi9saWJkdHJhY2UvY29tbW9uL2RydGkuYwpA
 QCAtMjAsNiArMjAsNyBAQAogICovCiAvKgogICogQ29weXJpZ2h0IDIwMDggU3VuIE1pY3Jvc3lz
 dGVtcywgSW5jLiAgQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAyMDEzIFZveGVy
 IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIFVzZSBpcyBzdWJqZWN0IHRvIGxpY2Vuc2Ug
 dGVybXMuCiAgKi8KIApAQCAtMTQ0LDcgKzE0NSw4IEBAIGR0cmFjZV9kb2ZfaW5pdCh2b2lkKQog
 CUxtaWRfdCBsbWlkOwogI2Vsc2UKIAl1X2xvbmcgbG1pZCA9IDA7Ci0JZG9mX3NlY190ICpzZWM7
 CisJZG9mX3NlY190ICpzZWMsICpzZWNzdGFydCwgKmRvZnN0cnRhYiwgKmRvZnByb2JlczsKKwlk
 b2ZfcHJvdmlkZXJfdCAqZG9mcHJvdmlkZXI7CiAJc2l6ZV90IGk7CiAjZW5kaWYKIAlpbnQgZmQ7
 CkBAIC0xNTIsMTIgKzE1NCwxMyBAQCBkdHJhY2VfZG9mX2luaXQodm9pZCkKICNpZiAhZGVmaW5l
 ZChzdW4pCiAJRWxmICplOwogCUVsZl9TY24gKnNjbiA9IE5VTEw7Ci0JRWxmX0RhdGEgKnN5bXRh
 YmRhdGEgPSBOVUxMLCAqZHluc3ltZGF0YSA9IE5VTEw7CisJRWxmX0RhdGEgKnN5bXRhYmRhdGEg
 PSBOVUxMLCAqZHluc3ltZGF0YSA9IE5VTEwsICpkb2ZkYXRhID0gTlVMTDsKKwlkb2ZfaGRyX3Qg
 KmRvZl9uZXh0ID0gTlVMTDsKIAlHRWxmX1NoZHIgc2hkcjsKIAlpbnQgZWZkLCBucHJvYmVzOwog
 CWNoYXIgKnM7CisJY2hhciAqZG9mc3RydGFicmF3OwogCXNpemVfdCBzaHN0cmlkeCwgc3ltdGFi
 aWR4ID0gMCwgZHluc3ltaWR4ID0gMDsKLQl1bnNpZ25lZCBjaGFyICpkb2ZzdHJ0YWIgPSBOVUxM
 OwogCXVuc2lnbmVkIGNoYXIgKmJ1ZjsKIAlpbnQgZml4ZWRwcm9iZXMgPSAwOwogI2VuZGlmCkBA
 IC0yMDksNyArMjEyLDkgQEAgZHRyYWNlX2RvZl9pbml0KHZvaWQpCiAJCX0gZWxzZSBpZiAoc2hk
 ci5zaF90eXBlID09IFNIVF9QUk9HQklUUykgewogCQkJcyA9IGVsZl9zdHJwdHIoZSwgc2hzdHJp
 ZHgsIHNoZHIuc2hfbmFtZSk7CiAJCQlpZiAgKHMgJiYgc3RyY21wKHMsICIuU1VOV19kb2YiKSA9
 PSAwKSB7Ci0JCQkJZG9mID0gZWxmX2dldGRhdGEoc2NuLCBOVUxMKS0+ZF9idWY7CisJCQkJZG9m
 ZGF0YSA9IGVsZl9nZXRkYXRhKHNjbiwgTlVMTCk7CisJCQkJZG9mID0gZG9mZGF0YS0+ZF9idWY7
 CisJCQkJYnJlYWs7CiAJCQl9CiAJCX0KIAl9CkBAIC0yMTksNiArMjI0LDkgQEAgZHRyYWNlX2Rv
 Zl9pbml0KHZvaWQpCiAJCWNsb3NlKGVmZCk7CiAJCXJldHVybjsKIAl9CisKKwl3aGlsZSAoKGNo
 YXIgKikgZG9mIDwgKGNoYXIgKikgZG9mZGF0YS0+ZF9idWYgKyBkb2ZkYXRhLT5kX3NpemUpIHsK
 KwkJZG9mX25leHQgPSAodm9pZCAqKSAoKGNoYXIgKikgZG9mICsgZG9mLT5kb2ZoX2ZpbGVzeik7
 CiAjZW5kaWYKIAogCWlmIChkb2YtPmRvZmhfaWRlbnRbRE9GX0lEX01BRzBdICE9IERPRl9NQUdf
 TUFHMCB8fApAQCAtMjkwLDM0ICsyOTgsNDkgQEAgZHRyYWNlX2RvZl9pbml0KHZvaWQpCiAJICog
 V2UgYXJlIGFzc3VtaW5nIHRoZSBudW1iZXIgb2YgcHJvYmVzIGlzIGxlc3MgdGhhbiB0aGUgbnVt
 YmVyIG9mCiAJICogc3ltYm9scyAobGliYyBjYW4gaGF2ZSA0ayBzeW1ib2xzLCBmb3IgZXhhbXBs
 ZSkuCiAJICovCi0Jc2VjID0gKGRvZl9zZWNfdCAqKShkb2YgKyAxKTsKKwlzZWNzdGFydCA9IHNl
 YyA9IChkb2Zfc2VjX3QgKikoZG9mICsgMSk7CiAJYnVmID0gKGNoYXIgKilkb2Y7CiAJZm9yIChp
 ID0gMDsgaSA8IGRvZi0+ZG9maF9zZWNudW07IGkrKywgc2VjKyspIHsKLQkJaWYgKHNlYy0+ZG9m
 c190eXBlID09IERPRl9TRUNUX1NUUlRBQikKLQkJCWRvZnN0cnRhYiA9ICh1bnNpZ25lZCBjaGFy
 ICopKGJ1ZiArIHNlYy0+ZG9mc19vZmZzZXQpOwotCQllbHNlIGlmIChzZWMtPmRvZnNfdHlwZSA9
 PSBET0ZfU0VDVF9QUk9CRVMgJiYgZG9mc3RydGFiKQorCQlpZiAoc2VjLT5kb2ZzX3R5cGUgIT0g
 RE9GX1NFQ1RfUFJPVklERVIpCisJCQljb250aW51ZTsKKworCQlkb2Zwcm92aWRlciA9ICh2b2lk
 ICopIChidWYgKyBzZWMtPmRvZnNfb2Zmc2V0KTsKKwkJZG9mc3RydGFiID0gc2Vjc3RhcnQgKyBk
 b2Zwcm92aWRlci0+ZG9mcHZfc3RydGFiOworCQlkb2Zwcm9iZXMgPSBzZWNzdGFydCArIGRvZnBy
 b3ZpZGVyLT5kb2Zwdl9wcm9iZXM7CisKKwkJaWYgKGRvZnN0cnRhYi0+ZG9mc190eXBlICE9IERP
 Rl9TRUNUX1NUUlRBQikgeworCQkJZnByaW50ZihzdGRlcnIsICJXQVJOSU5HOiBleHBlY3RlZCBT
 VFJUQUIgc2VjdGlvbiwgYnV0IGdvdCAlZFxuIiwKKwkJCQkJZG9mc3RydGFiLT5kb2ZzX3R5cGUp
 OwogCQkJYnJlYWs7Ci0JCi0JfQotCW5wcm9iZXMgPSBzZWMtPmRvZnNfc2l6ZSAvIHNlYy0+ZG9m
 c19lbnRzaXplOwotCWZpeHN5bWJvbChlLCBzeW10YWJkYXRhLCBzeW10YWJpZHgsIG5wcm9iZXMs
 IGJ1Ziwgc2VjLCAmZml4ZWRwcm9iZXMsCi0JICAgIGRvZnN0cnRhYik7Ci0JaWYgKGZpeGVkcHJv
 YmVzICE9IG5wcm9iZXMpIHsKLQkJLyoKLQkJICogSWYgd2UgaGF2ZW4ndCBmaXhlZCBhbGwgdGhl
 IHByb2JlcyB1c2luZyB0aGUKLQkJICogc3ltdGFiIHNlY3Rpb24sIGxvb2sgaW5zaWRlIHRoZSBk
 eW5zeW0KLQkJICogc2VjdGlvbi4KLQkJICovCi0JCWZpeHN5bWJvbChlLCBkeW5zeW1kYXRhLCBk
 eW5zeW1pZHgsIG5wcm9iZXMsIGJ1Ziwgc2VjLAotCQkgICAgJmZpeGVkcHJvYmVzLCBkb2ZzdHJ0
 YWIpOwotCX0KLQlpZiAoZml4ZWRwcm9iZXMgIT0gbnByb2JlcykgewotCQlmcHJpbnRmKHN0ZGVy
 ciwgIldBUk5JTkc6IG51bWJlciBvZiBwcm9iZXMgIgotCQkgICAgImZpeGVkIGRvZXMgbm90IG1h
 dGNoIHRoZSBudW1iZXIgb2YgIgotCQkgICAgImRlZmluZWQgcHJvYmVzICglZCAhPSAlZCwgIgot
 CQkgICAgInJlc3BlY3RpdmVseSlcbiIsIGZpeGVkcHJvYmVzLCBucHJvYmVzKTsKLQkJZnByaW50
 ZihzdGRlcnIsICJXQVJOSU5HOiBzb21lIHByb2JlcyBtaWdodCAiCi0JCSAgICAibm90IGZpcmUg
 b3IgeW91ciBwcm9ncmFtIG1pZ2h0IGNyYXNoXG4iKTsKKwkJfQorCQlpZiAoZG9mcHJvYmVzLT5k
 b2ZzX3R5cGUgIT0gRE9GX1NFQ1RfUFJPQkVTKSB7CisJCQlmcHJpbnRmKHN0ZGVyciwgIldBUk5J
 Tkc6IGV4cGVjdGVkIFBST0JFUyBzZWN0aW9uLCBidXQgZ290ICVkXG4iLAorCQkJICAgIGRvZnBy
 b2Jlcy0+ZG9mc190eXBlKTsKKwkJCWJyZWFrOworCQl9CisKKwkJZHByaW50ZigxLCAiZm91bmQg
 cHJvdmlkZXIgJXBcbiIsIGRvZnByb3ZpZGVyKTsKKwkJZG9mc3RydGFicmF3ID0gKGNoYXIgKiko
 YnVmICsgZG9mc3RydGFiLT5kb2ZzX29mZnNldCk7CisJCW5wcm9iZXMgPSBkb2Zwcm9iZXMtPmRv
 ZnNfc2l6ZSAvIGRvZnByb2Jlcy0+ZG9mc19lbnRzaXplOworCQlmaXhzeW1ib2woZSwgc3ltdGFi
 ZGF0YSwgc3ltdGFiaWR4LCBucHJvYmVzLCBidWYsIGRvZnByb2JlcywgJmZpeGVkcHJvYmVzLAor
 CQkJCWRvZnN0cnRhYnJhdyk7CisJCWlmIChmaXhlZHByb2JlcyAhPSBucHJvYmVzKSB7CisJCQkv
 KgorCQkJICogSWYgd2UgaGF2ZW4ndCBmaXhlZCBhbGwgdGhlIHByb2JlcyB1c2luZyB0aGUKKwkJ
 CSAqIHN5bXRhYiBzZWN0aW9uLCBsb29rIGluc2lkZSB0aGUgZHluc3ltCisJCQkgKiBzZWN0aW9u
 LgorCQkJICovCisJCQlmaXhzeW1ib2woZSwgZHluc3ltZGF0YSwgZHluc3ltaWR4LCBucHJvYmVz
 LCBidWYsIGRvZnByb2JlcywKKwkJCQkJJmZpeGVkcHJvYmVzLCBkb2ZzdHJ0YWJyYXcpOworCQl9
 CisJCWlmIChmaXhlZHByb2JlcyAhPSBucHJvYmVzKSB7CisJCQlmcHJpbnRmKHN0ZGVyciwgIldB
 Uk5JTkc6IG51bWJlciBvZiBwcm9iZXMgIgorCQkJICAgICJmaXhlZCBkb2VzIG5vdCBtYXRjaCB0
 aGUgbnVtYmVyIG9mICIKKwkJCSAgICAiZGVmaW5lZCBwcm9iZXMgKCVkICE9ICVkLCAiCisJCQkg
 ICAgInJlc3BlY3RpdmVseSlcbiIsIGZpeGVkcHJvYmVzLCBucHJvYmVzKTsKKwkJCWZwcmludGYo
 c3RkZXJyLCAiV0FSTklORzogc29tZSBwcm9iZXMgbWlnaHQgIgorCQkJICAgICJub3QgZmlyZSBv
 ciB5b3VyIHByb2dyYW0gbWlnaHQgY3Jhc2hcbiIpOworCQl9CiAJfQogI2VuZGlmCiAJaWYgKChn
 ZW4gPSBpb2N0bChmZCwgRFRSQUNFSElPQ19BRERET0YsICZkaCkpID09IC0xKQpAQCAtMzMwLDcg
 KzM1MywxMiBAQCBkdHJhY2VfZG9mX2luaXQodm9pZCkKIAl9CiAKIAkodm9pZCkgY2xvc2UoZmQp
 OworCiAjaWYgIWRlZmluZWQoc3VuKQorCQkvKiBFbmQgb2Ygd2hpbGUgbG9vcCAqLworCQlkb2Yg
 PSBkb2ZfbmV4dDsKKwl9CisKIAllbGZfZW5kKGUpOwogCSh2b2lkKSBjbG9zZShlZmQpOwogI2Vu
 ZGlmCg==
 --089e0153673e53437b04f2d565b7--