bin/186294: calendar(1): calendar' preprocessor process comments
Romain Tartière
romain at blogreen.org
Wed Feb 19 18:30:01 UTC 2014
The following reply was made to PR bin/186294; it has been noted by GNATS.
From: Romain =?iso-8859-1?Q?Tarti=E8re?= <romain at blogreen.org>
To: oliver <oliver at beefrankly.org>
Cc: bug-followup at FreeBSD.org
Subject: Re: bin/186294: calendar(1): calendar' preprocessor process
comments
Date: Wed, 19 Feb 2014 19:29:00 +0100
--6e7ZaeXHKrTJCxdu
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi Oliver,
On Wed, Feb 19, 2014 at 06:16:25PM +0100, oliver wrote:
> sorry wrong patch file, patch again - correct version.
After applying this patch, I confirm this problem is fixed.
> + } else if (idx_ts !=3D NULL && idx_te =3D=3D NULL) {
> + if (cf =3D=3D 0) {
> + cf =3D 1;
> + while (buf++ !=3D idx_ts);=20
^^^^^^^^^^^^^^^^^^^^^^^
While copying/pasting the patch, this line confused me a bit. Isn't it
more obvious to write this as a simple assignment ?
> buf =3D idx_ts + 1;
Thanks!
Romain
--=20
Romain Tarti=E8re <romain at blogreen.org> http://romain.blogreen.org/
pgp: 8234 9A78 E7C0 B807 0B59 80FF BA4D 1D95 5112 336F (ID: 0x5112336F)
(plain text =3Dnon-HTML=3D PGP/GPG encrypted/signed e-mail much appreciated)
--6e7ZaeXHKrTJCxdu
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)
iQGcBAEBAgAGBQJTBPfrAAoJELpNHZVREjNvI7kL/26Y8PN8mqeqeXpfZwDY1c7k
vsOpqAqbM1FSSomabTsmRXriPL+xDBg+KXtnnxiHZuW1dLR0UrhQq4n39JaG2eWi
6uuNV/QHiFt0FM+gcUtL8zIBWchQ1dnVPVYpiw0pZ1zWof8yAHMMnfGo+m+gSE0D
D/bZqSN2qf/LD+4TQnNJ/66tcIuIgKNc0TbVyo44zYo8tWvBSOwgDkcyCg4uVI/w
VI7a4xgGcG76uOHs4KBqPHPBCcxLM83b8Wri26Ye9xi2+P8edBVMnqmLmZn9uz/w
qzkWyeI4ld9WmqVNIUQCGOB32h4CodvfPHC4kdAmNjH7erXG65nmaJ0fjwL9Fz6m
svHH3lAvHawe2mQzQFehnlwRSzHvGZWwr9RMEMiCjrRZxtnHMHlUyJOUX+pIS2Oc
OZSbCWCVRguy03riaBtLIKgFcQDKbaSjj+rZHkQ3os45Ioh96+21jkKqiWPGgxNX
zWhFA7c7acw43wuLY+8SSuYAkhj86UX7SqcxjRTzlA==
=Y74c
-----END PGP SIGNATURE-----
--6e7ZaeXHKrTJCxdu--
More information about the freebsd-bugs
mailing list