[Bug 192734] New: [build] [patch] clang uses DPADD for sources (should use DPSRCS instead); fails checkdpadd

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192734

            Bug ID: 192734
           Summary: [build] [patch] clang uses DPADD for sources (should
                    use DPSRCS instead); fails checkdpadd
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Severity: Affects Some People
          Priority: ---
         Component: conf
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: yaneurabeya at gmail.com

As reported by bde, the clang portion of the build system uses DPADD to specify
source files, which makes "make checkdpadd" whine like so:

===> lib/clang/libclanganalysis (checkdpadd)
/usr/src/lib/clang/libclanganalysis
DPADD -> AttrList.inc.h Attrs.inc.h CommentCommandList.inc.h CommentNodes.inc.h
DeclNodes.inc.h DiagnosticAnalysisKinds.inc.h DiagnosticCommonKinds.inc.h
StmtNodes.inc.h
LDADD ->

DPADD should only be used by libraries.

If I change DPADD to DPSRCS, make checkdpadd passes. I verified that the
dependency information was correct and it compiles, but I haven't verified that
everything works yet.

Here's the patch:

% git diff clang.build.mk 
diff --git a/lib/clang/clang.build.mk b/lib/clang/clang.build.mk
index 5465272..3b30fe7 100644
--- a/lib/clang/clang.build.mk
+++ b/lib/clang/clang.build.mk
@@ -237,5 +237,5 @@ Checkers.inc.h:
${CLANG_SRCS}/lib/StaticAnalyzer/Checkers/Checkers.td
 .endfor

 SRCS+=         ${TGHDRS:C/$/.inc.h/}
-DPADD+=                ${TGHDRS:C/$/.inc.h/}
+DPSRCS+=       ${TGHDRS:C/$/.inc.h/}
 CLEANFILES+=   ${TGHDRS:C/$/.inc.h/} ${TGHDRS:C/$/.inc.d/}

-- 
You are receiving this mail because:
You are the assignee for the bug.