[Bug 192733] New: [build] [patch] lib/libcuse: checkdpadd failure (missing DPADD for LIBPTHREAD)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192733

            Bug ID: 192733
           Summary: [build] [patch] lib/libcuse: checkdpadd failure
                    (missing DPADD for LIBPTHREAD)
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Severity: Affects Some People
          Priority: ---
         Component: conf
          Assignee: freebsd-bugs at FreeBSD.org
          Reporter: yaneurabeya at gmail.com

lib/libcuse/Makefile is missing DPADD for libpthread:

Before the fix:

% (cd /usr/src.svn/lib/libcuse/; make checkdpadd)
/usr/src.svn/lib/libcuse
DPADD -> 
LDADD -> -lpthread

After the fix:

% make checkdpadd
% git diff Makefile 
diff --git a/lib/libcuse/Makefile b/lib/libcuse/Makefile
index 6269cbe..f547bc2 100644
--- a/lib/libcuse/Makefile
+++ b/lib/libcuse/Makefile
@@ -30,13 +30,13 @@ SHLIB_MINOR=        0
 SRCS=          cuse_lib.c
 INCS=          cuse.h
 MAN=           cuse.3
-PTHREAD_LIBS?= -lpthread
 CFLAGS+=       -D_GNU_SOURCE
 .if defined(HAVE_DEBUG)
 CFLAGS+=       -g
 CFLAGS+=       -DHAVE_DEBUG
 .endif
-LDADD+=        ${PTHREAD_LIBS}
+DPADD+=        ${LIBPTHREAD}
+LDADD+=        -lpthread

 MLINKS=
 MLINKS+= cuse.3 cuse_alloc_unit_number.3

-- 
You are receiving this mail because:
You are the assignee for the bug.