kern/179083: [netmap] [patch] Invalid index calucation in netmap macro expansion

[Luigi Rizzo]

On Thu, May 30, 2013 at 07:43:47AM +0000, linimon at freebsd.org wrote:
> Old Synopsis: Invalid index calucation in netmap macro expansion
> New Synopsis: [netmap] [patch] Invalid index calucation in netmap macro expansion
> 
> Responsible-Changed-From-To: freebsd-bugs->freebsd-net
> Responsible-Changed-By: linimon
> Responsible-Changed-When: Thu May 30 07:43:27 UTC 2013
> Responsible-Changed-Why: 
> Over to maintainer(s).

Thanks for the report.

The macro is correct as implemented.
The problem, in case, is in the description in netmap_user.h which
is confusing and should be improved as follows:

-*      char *buf = NETMAP_BUF(ring, index) returns a pointer to
-*              the i-th buffer
+*      char *buf = NETMAP_BUF(ring, x) returns a pointer to
+*              the buffer numbered 'x'

This will be committed soon, so please close the PR

cheers
luigi

> http://www.freebsd.org/cgi/query-pr.cgi?pr=179083
> _______________________________________________
> freebsd-net at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe at freebsd.org"