conf/178963: make release is broken

[kit]

>Number:         178963
>Category:       conf
>Synopsis:       make release is broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 25 05:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     kit
>Release:        FreeBSD 10.0-CURRENT
>Organization:
>Environment:
FreeBSD passion 10.0-CURRENT FreeBSD 10.0-CURRENT #0: Sat Mar  2 15:31:51 MYT 2013     ktsin at passion.yahoo.com:/tmp/obj/usr/src/sys/PASSION  amd64
>Description:
make release is broken due to NO_ROOT changes added to Makefile.inc1 starting r250707.

it appears that DESTDIR is incorrect because INSTALL_DDIR is undefined or empty when NO_ROOT isn't set.

mkdir -p dist
cd /usr/src/release/.. && make TARGET_ARCH=amd64 TARGET=amd64 distributekernel packagekernel DISTDIR=/tmp/obj/usr/src/release/dist
mkdir -p //tmp/obj/usr/src/release/dist
cd /tmp/obj/usr/src/sys/GENERIC;  MAKEOBJDIRPREFIX=/tmp/obj MACHINE_ARCH=amd64 MACHINE=amd64 CPUTYPE= GROFF_BIN_PATH=/tmp/obj/usr/src/tmp/legacy/usr/bin GROFF_FONT_PATH=/tmp/obj/usr/src/tmp/legacy/usr/share/groff_font GROFF_TMAC_PATH=/tmp/obj/usr/src/tmp/legacy/usr/share/tmac PATH=/tmp/obj/usr/src/tmp/legacy/usr/sbin:/tmp/obj/usr/src/tmp/legacy/usr/bin:/tmp/obj/usr/src/tmp/legacy/usr/games:/tmp/obj/usr/src/tmp/legacy/bin:/tmp/obj/usr/src/tmp/usr/sbin:/tmp/obj/usr/src/tmp/usr/bin:/tmp/obj/usr/src/tmp/usr/games:  LD_LIBRARY_PATH=  PATH_LOCALE=/locale    PATH=/tmp/obj/usr/src/tmp/legacy/usr/sbin:/tmp/obj/usr/src/tmp/legacy/usr/bin:/tmp/obj/usr/src/tmp/legacy/usr/games:/tmp/obj/usr/src/tmp/legacy/bin:/tmp/obj/usr/src/tmp/usr/sbin:/tmp/obj/usr/src/tmp/usr/bin:/tmp/obj/usr/src/tmp/usr/games:/sbin:/bin:/usr/sbin:/usr/bin /tmp/obj/usr/src/make.amd64/make KERNEL=kernel  DESTDIR=/kernel  install
mkdir -p /kernel/boot/kernel
mkdir: /kernel: Read-only file system
*** Error code 1

Stop.
make: stopped in /tmp/obj/usr/src/sys/GENERIC
*** Error code 1

Stop.
make: stopped in /usr/src
*** [distributekernel] Error code 1

Stop in /usr/src.
*** [kernel.txz] Error code 1

Stop in /usr/src/release.
*** [release] Error code 1

Stop in /usr/src/release.

>How-To-Repeat:

>Fix:
set NO_ROOT=1 even if running make release under root user?

>Release-Note:
>Audit-Trail:
>Unformatted: