kern/178359: [geom] [patch] geom_eli: support external metadata

[Andrew Romanenko]

On 05/06/2013 07:32 AM, Scot Hetzel wrote:
> On Sun, May 5, 2013 at 10:51 PM, Scot Hetzel <swhetzel at gmail.com> wrote:
>> On Sun, May 5, 2013 at 7:54 PM,  <linimon at freebsd.org> wrote:
>>> Old Synopsis: geom_eli: support external metadata
>>> New Synopsis: [geom] [patch] geom_eli: support external metadata
>>>
>>> Responsible-Changed-From-To: freebsd-bugs->freebsd-geom
>>> Responsible-Changed-By: linimon
>>> Responsible-Changed-When: Mon May 6 00:54:16 UTC 2013
>>> Responsible-Changed-Why:
>>> Over to maintainer(s).
>>>
>>> http://www.freebsd.org/cgi/query-pr.cgi?pr=178359
>> I had a quick look at the patch and noticed that it is using -H for
>> init method, but -h for the attach, configure, setkey, delkey, resume,
>> resize, and dump methods.
>>
>> The patch also shows that it removes the -h option from the init
>> method.  I looked at the -Current and release/9.1.0 sources for
>> geom_eli.8 and they don't have the -h option.  I suspect it was a
>> local modification that was made before this patch was created.
>>
> My mistake, the -h option was in the geom_eli.c file, but only in the
> comment for the commands.  According to the original commit:
>
> https://svnweb.freebsd.org/base?view=revision&revision=148456
>
> The -h was never in the class_commands for the init method.  Not sure
> what it was there for (maybe to display the usuage?).
>
>> It would be best that init, attach, configure, setkey, delkey, resume,
>> resize, and dump methods use the same option (-h or -H) to specify the
>> headerfile.
>>
> So for now it looks like using -H would be the better option for all
> these methods.
>
>
Fixed, using '-H' for all methods
(updated patch in the attachment)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: geli.patch
Type: text/x-patch
Size: 23891 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-bugs/attachments/20130506/ce8ea047/attachment.bin>