kern/175648: commit references a PR

dfilter service dfilter at FreeBSD.ORG
Mon Jan 28 16:10:01 UTC 2013


The following reply was made to PR kern/175648; it has been noted by GNATS.

From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: kern/175648: commit references a PR
Date: Mon, 28 Jan 2013 15:48:45 +0000 (UTC)

 Author: jhb
 Date: Mon Jan 28 15:48:31 2013
 New Revision: 246035
 URL: http://svnweb.freebsd.org/changeset/base/246035
 
 Log:
   - Compute the correct size to reallocate when doubling the size of the
     array of loaded objects to avoid a buffer overrun.
   - Use reallocf() to avoid leaking memory if the realloc() fails.
   
   PR:		kern/175648
   Submitted by:	yuri at rawbw.com (1)
   MFC after:	1 week
 
 Modified:
   head/lib/libproc/proc_rtld.c
 
 Modified: head/lib/libproc/proc_rtld.c
 ==============================================================================
 --- head/lib/libproc/proc_rtld.c	Mon Jan 28 12:58:37 2013	(r246034)
 +++ head/lib/libproc/proc_rtld.c	Mon Jan 28 15:48:31 2013	(r246035)
 @@ -44,7 +44,8 @@ map_iter(const rd_loadobj_t *lop, void *
  
  	if (phdl->nobjs >= phdl->rdobjsz) {
  		phdl->rdobjsz *= 2;
 -		phdl->rdobjs = realloc(phdl->rdobjs, phdl->rdobjsz);
 +		phdl->rdobjs = reallocf(phdl->rdobjs, sizeof(*phdl->rdobjs) *
 +		    phdl->rdobjsz);
  		if (phdl->rdobjs == NULL)
  			return (-1);
  	}
 _______________________________________________
 svn-src-all at freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"
 


More information about the freebsd-bugs mailing list