kern/175546: Kernel compilation crash in bktr driver

[Michael Pounov]

>Number:         175546
>Category:       kern
>Synopsis:       Kernel compilation crash in bktr driver
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 24 16:10:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Michael Pounov
>Release:        FreeBSD-current
>Organization:
ELWIX
>Environment:
FreeBSD elwix.aitnet.org 10.0-CURRENT FreeBSD 10.0-CURRENT #31: Thu Jan 24 14:33:42 EET 2013     root at elwix.aitnet.org:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
When include bktr driver into kernel with this lines:

device          bktr
options         BKTR_NEW_MSP34XX_DRIVER

compilation stops due to error in msp34xx.c

kproc_create() have changed arguments of function.
>How-To-Repeat:
Include into kernel config this lines:

device          bktr
options         BKTR_NEW_MSP34XX_DRIVER

>Fix:
--- msp34xx.c	2012-11-22 11:08:13.000000000 +0200
+++ /home/fbsd_work.src/src/sys/dev/bktr/msp34xx.c	2013-01-24 17:46:17.000000000 +0200
@@ -1198,7 +1198,7 @@
 
 	/* startup control thread */
 	err = kproc_create(msp->simple ? msp3410d_thread : msp3400c_thread,
-			     bktr, &msp->kthread, (RFFDG | RFPROC), 0,
+			     bktr, &msp->kthread, (RFFDG | RFPROC), 0, "%s",
 			     msp->threaddesc);
 	if (err) {
 		printf("%s: Error returned by kproc_create: %d", bktr_name(bktr), err);


Patch attached with submission follows:

--- msp34xx.c	2012-11-22 11:08:13.000000000 +0200
+++ /home/fbsd_work.src/src/sys/dev/bktr/msp34xx.c	2013-01-24 17:46:17.000000000 +0200
@@ -1198,7 +1198,7 @@
 
 	/* startup control thread */
 	err = kproc_create(msp->simple ? msp3410d_thread : msp3400c_thread,
-			     bktr, &msp->kthread, (RFFDG | RFPROC), 0,
+			     bktr, &msp->kthread, (RFFDG | RFPROC), 0, "%s",
 			     msp->threaddesc);
 	if (err) {
 		printf("%s: Error returned by kproc_create: %d", bktr_name(bktr), err);


>Release-Note:
>Audit-Trail:
>Unformatted: