conf/175006: /etc/rc.d/ip6addrctl exits not 0 when ip6addrctl_verbose="NO"

[Tatsuki Makino]

>Number:         175006
>Category:       conf
>Synopsis:       /etc/rc.d/ip6addrctl exits not 0 when ip6addrctl_verbose="NO"
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 05 13:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Tatsuki Makino
>Release:        FreeBSD 9.1-PRERELEASE i386
>Organization:
>Environment:
FreeBSD T0.test 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #0 r244396M: Tue Dec 18 23:49:46 UTC 2012     root at T0.test:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
The exit status of /etc/rc.d/ip6addrctl is not 0.
"checkyesno ip6addrctl_verbose" is affected it.
>How-To-Repeat:
% # on 9-stable and 8-stable
% su
# tcsh
# set printexitvalue
# echo 'ip6addrctl_verbose="NO"' >> /etc/rc.conf
# /etc/rc.d/ip6addrctl start
Exit 1
>Fix:
patch

Patch attached with submission follows:

Index: base/head/etc/rc.d/ip6addrctl
===================================================================
--- base/head/etc/rc.d/ip6addrctl	(revision 245056)
+++ base/head/etc/rc.d/ip6addrctl	(working copy)
@@ -35,6 +35,7 @@
 	ip6addrctl add ::/96		20	3
 	ip6addrctl add ::ffff:0:0/96	10	4
 	checkyesno ip6addrctl_verbose && ip6addrctl
+	return 0
 }
 
 ip6addrctl_prefer_ipv4()
@@ -48,6 +49,7 @@
 	ip6addrctl add 2002::/16	20	3
 	ip6addrctl add ::/96		10	4
 	checkyesno ip6addrctl_verbose && ip6addrctl
+	return 0
 }
 
 ip6addrctl_start()
@@ -60,7 +62,7 @@
 		if [ -r "${config_file}" -a -s "${config_file}" ]; then
 			ip6addrctl flush >/dev/null 2>&1
 			ip6addrctl install "${config_file}"
-			checkyesno ip6addrctl_verbose && ip6addrctl
+			checkyesno ip6addrctl_verbose && ip6addrctl || true
 		else
 			if checkyesno ipv6_activate_all_interfaces; then
 				ip6addrctl_prefer_ipv6


>Release-Note:
>Audit-Trail:
>Unformatted: