kern/176027: flow control systcl consistency for em drivers

[Gleb Smirnoff]

The following reply was made to PR kern/176027; it has been noted by GNATS.

From: Gleb Smirnoff <glebius at FreeBSD.org>
To: Olivier Cochard-Labbe <olivier at cochard.me>
Cc: freebsd-gnats-submit at FreeBSD.org, jfv at FreeBSD.org
Subject: Re: kern/176027: flow control systcl consistency for em drivers
Date: Mon, 11 Feb 2013 17:10:20 +0400

 On Mon, Feb 11, 2013 at 11:48:51AM +0000, Olivier Cochard-Labbe wrote:
 O> 
 O> >Number:         176027
 O> >Category:       kern
 O> >Synopsis:       flow control systcl consistency for em drivers
 O> >Confidential:   no
 O> >Severity:       non-critical
 O> >Priority:       low
 O> >Responsible:    freebsd-bugs
 O> >State:          open
 O> >Quarter:        
 O> >Keywords:       
 O> >Date-Required:
 O> >Class:          sw-bug
 O> >Submitter-Id:   current-users
 O> >Arrival-Date:   Mon Feb 11 11:50:00 UTC 2013
 O> >Closed-Date:
 O> >Last-Modified:
 O> >Originator:     Olivier Cochard-Labbe
 O> >Release:        9.1-RELEASE
 O> >Organization:
 O> BSD Router Project
 O> >Environment:
 O> >Description:
 O> On my systems em(4) flow control can be configured with:
 O> dev.em.0.fc (if chipset depends of if_em.c)
 O> or
 O> dev.em.0.flow_control (if chipset depends of if_lem.c)
 O> 
 O> For more consistency (but a POLA?), here is a small patch for if_lem.c that replace 'flow_control' usage by 'fc' usage.
 O> 
 O> 
 O> >How-To-Repeat:
 O> 
 O> >Fix:
 O> Applying the patch.
 O> 
 O> Patch attached with submission follows:
 O> 
 O> --- sys/dev/e1000/if_lem.c.orig	2013-02-11 10:21:00.000000000 +0100
 O> +++ sys/dev/e1000/if_lem.c	2013-02-11 10:21:20.000000000 +0100
 O> @@ -458,7 +458,7 @@
 O>  #endif
 O>  
 O>          /* Sysctl for setting the interface flow control */
 O> -	lem_set_flow_cntrl(adapter, "flow_control",
 O> +	lem_set_flow_cntrl(adapter, "fc",
 O>  	    "flow control setting",
 O>  	    &adapter->fc_setting, lem_fc_setting);
 
 I'd prefer the opposite: substitute for "flow_control" in if_em.c.
 
 Jack, what's your opinion?
 
 -- 
 Totus tuus, Glebius.