bin/184648: Regression: some comments in calendar OK in 9.1, fail in 10.0-BETA4

[Julian H. Stacey]

>Number:         184648
>Category:       bin
>Synopsis:       Regression: some comments in calendar OK in 9.1, fail in 10.0-BETA4
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 10 01:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Julian H. Stacey
>Release:        FreeBSD 10.0-BETA4 amd64
>Organization:
/home/jhs/.organization
>Environment:
System: FreeBSD lapr.js.berklix.net 10.0-BETA4 FreeBSD 10.0-BETA4 #0: Tue Dec 3 20:11:41 CET 2013 jhs at lapr.js.berklix.net:/usr/src/sys/amd64/compile/LAPR.small amd64


	
>Description:
	Regression: some comments in calendar OK in 9.1, fail in 10.0-BETA4

>How-To-Repeat:
	
	Put this in your ~/.calendar/calendar 
	(Either do not use a mouse to copy, or if you do, repair tabs after)
--- cut --- Start of Input Test Data
Wednesday	Test 1
/* Test 1, First of 2 lines of comments beginning on left margin
  Test 1, second of 2 lines, beginning with 2 spaces */

Wednesday	Test 2
/* Test 2, First of 2 lines of comments beginning on left margin 
	Test 2, second of 2 lines, beginning with 1 tab */

Wednesday	Test 3
  /* Test 3, First of 2 lines of comments beginning with 2 spaces
  Test 3, second of 2 lines, beginning with 2 spaces 3 */

Wednesday	Test 4
	/* Test 4, First of 2 lines of comments beginning with 1 tab
  Test 4, second of 2 lines, beginning with 2 spaces */

Wednesday	Test 5
	/* Test 5, First of 2 lines of comments beginning with 1 tab
	Test 5, second of 2 lines, beginning with 1 tab */
--- cut --- End Of Input Test Data, + Start of good output from 9.1-RELEASE
Dec 11* Test 5
Dec 11* Test 4
Dec 11* Test 3
Dec 11* Test 2
Dec 11* Test 1
--- cut --- Start of bad output from 10.0-BETA4
Dec 11*	Test 5
	/* Test 5, First of 2 lines of comments beginning with 1 tab
	Test 5, second of 2 lines, beginning with 1 tab */
Dec 11*	Test 4
	/* Test 4, First of 2 lines of comments beginning with 1 tab
Dec 11*	Test 3
Dec 11*	Test 2
	Test 2, second of 2 lines, beginning with 1 tab */
Dec 11*	Test 1
--- cut ---

>Fix:

	
I assume it's yet another problem from changing the compiler & thus cpp.
It only fails wth a leading tab, not leading spaces.

One could weasel out by quoting man calendar text
	"If the first character in the line is a <tab>
	character, it is treated as a continuation of the
	previous line"
which preceeds
	"Empty lines and lines pro- tected by the C commenting
	syntax (/* ... */) are ignored."
But it used to work, & the manual has not changed its wording,
just the binary now functions worse.

I'll keep a note of this send-pr at:
http://www.berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/send-pr.comments_delimiting+cpp.no_customise
>Release-Note:
>Audit-Trail:
>Unformatted: