kern/184638: ncurses: bump ospeed from short to int

[Christian Weisgerber]

>Number:         184638
>Category:       kern
>Synopsis:       ncurses: bump ospeed from short to int
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 09 16:50:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Christian Weisgerber
>Release:        FreeBSD 9.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD lorvorc.mips.inka.de 9.2-STABLE FreeBSD 9.2-STABLE #0 r259069: Sat Dec 7 15:52:28 CET 2013 naddy at lorvorc.mips.inka.de:/usr/obj/usr/src/sys/GENERIC amd64

>Description:

In FreeBSD (all supported versions) the type of the ospeed variable
is defined as "short" in lib/ncurses/ncurses/Makefile.  However,
in contrib/ncurses/ncurses/tinfo/lib_baudrate.c the USE_OLD_TTY
hack is disabled for FreeBSD >=7 since the required 4.3BSD compatibility
goo went away.  As a result, ospeed now needs to be able to hold
values up to 921600 (cf. <sys/_termios.h>), so it must be bumped
from short to int.

Obviously this is a binary-incompatible API change.

Arguably, switching ospeed's type is more intrusive than having
garbage values in ospeed, but we should strive for correctness.

(FWIW, OpenBSD, which is facing the same issue, will switch to int
ospeed.)

>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted: