kern/177888: Missing mutex unlock - deadlock multicast subsystem

[Sven-Thorsten Dietrich]

>Number:         177888
>Category:       kern
>Synopsis:       Missing mutex unlock - deadlock multicast subsystem
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 16 19:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Sven-Thorsten Dietrich
>Release:        head / 9.1.0
>Organization:
Vyatta
>Environment:
N/A
>Description:
return inside locked critical section
>How-To-Repeat:
see patch, run set_api_config() appropriately
>Fix:
apply patch

Patch attached with submission follows:

Index: netinet/ip_mroute.c
===================================================================
--- netinet/ip_mroute.c	(revision 249557)
+++ netinet/ip_mroute.c	(working copy)
@@ -825,6 +825,7 @@
     for (i = 0; i < mfchashsize; i++) {
 	if (LIST_FIRST(&V_mfchashtbl[i]) != NULL) {
 	    *apival = 0;
+            MFC_UNLOCK();
 	    return EPERM;
 	}
     }


>Release-Note:
>Audit-Trail:
>Unformatted: