kern/177759: commit references a PR

dfilter service dfilter at FreeBSD.ORG
Tue Apr 16 18:00:02 UTC 2013


The following reply was made to PR kern/177759; it has been noted by GNATS.

From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: kern/177759: commit references a PR
Date: Tue, 16 Apr 2013 17:50:40 +0000 (UTC)

 Author: dim
 Date: Tue Apr 16 17:50:20 2013
 New Revision: 249557
 URL: http://svnweb.freebsd.org/changeset/base/249557
 
 Log:
   MFC r249449:
   
   Fix undefined behaviour in several gpio_pin_setflags() routines (under
   sys/arm and sys/mips), squelching the clang 3.3 warnings about this.
   
   Noticed by:	tinderbox and many irate spectators
   Submitted by:	Luiz Otavio O Souza <loos.br at gmail.com>
   PR:		kern/177759
 
 Modified:
   stable/8/sys/mips/atheros/ar71xx_gpio.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/mips/   (props changed)
 
 Modified: stable/8/sys/mips/atheros/ar71xx_gpio.c
 ==============================================================================
 --- stable/8/sys/mips/atheros/ar71xx_gpio.c	Tue Apr 16 17:47:13 2013	(r249556)
 +++ stable/8/sys/mips/atheros/ar71xx_gpio.c	Tue Apr 16 17:50:20 2013	(r249557)
 @@ -225,8 +225,8 @@ ar71xx_gpio_pin_setflags(device_t dev, u
  	if (i >= sc->gpio_npins)
  		return (EINVAL);
  
 -	/* Filter out unwanted flags */
 -	if ((flags &= sc->gpio_pins[i].gp_caps) != flags)
 +	/* Check for unwanted flags. */
 +	if ((flags & sc->gpio_pins[i].gp_caps) != flags)
  		return (EINVAL);
  
  	/* Can't mix input/output together */
 _______________________________________________
 svn-src-all at freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"
 


More information about the freebsd-bugs mailing list