misc/171779: make option NO_FSCHG incomplete

[Gareth de Vaux]

>Number:         171779
>Category:       misc
>Synopsis:       make option NO_FSCHG incomplete
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 19 13:30:21 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Gareth de Vaux
>Release:        8.3-STABLE
>Organization:
iThemba LABS
>Environment:
FreeBSD XXX 8.3-STABLE FreeBSD 8.3-STABLE #0: Wed Sep 12 22:15:43 SAST 2012     root at XXX:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
Outlined in http://lists.freebsd.org/pipermail/freebsd-stable/2012-September/069610.html

Running a make installworld with NO_FSCHG defined fails to prevent /usr/bin/passwd being installed with the schg flag.

>How-To-Repeat:
chflags -R noschg /
NO_FSCHG=true
make installworld
ls -lo /usr/bin/passwd

>Fix:
add conditional to 'afterinstall' in /usr/src/usr.bin/passwd/Makefile:

.if !defined(NO_FSCHG)
afterinstall:
        -chflags schg ${DESTDIR}${BINDIR}/passwd
.endif


>Release-Note:
>Audit-Trail:
>Unformatted: