kern/173840: snd_hda(4) volume mixer not working anymore

[David Demelier]

The following reply was made to PR kern/173840; it has been noted by GNATS.

From: David Demelier <demelier.david at gmail.com>
To: Alexander Motin <mav at FreeBSD.org>
Cc: bug-followup at FreeBSD.org
Subject: Re: kern/173840: snd_hda(4) volume mixer not working anymore
Date: Sat, 24 Nov 2012 15:49:00 +0100

 On 23/11/2012 01:52, Alexander Motin wrote:
 > Hi.
 >
 > I can't qualify it is as a driver bug. At most it is behavior change.
 > There are two signal paths from the DACs to the pins in this CODEC:
 > direct and via the mixer. And there is no volume control on the direct
 > path. In your specific case it is possible to route signal via the mixer
 > and control it there. But present driver is unable to make reasonable
 > selection in such cases. Probably previously driver version did the
 > right thing by accident.
 >
 > Patch below should probably help in your case, but it is not universal
 > enough to commit it.
 >
 > --- hdaa_patches.c      (revision 243182)
 > +++ hdaa_patches.c      (working copy)
 > @@ -442,6 +442,14 @@ hdaa_patch(struct hdaa_devinfo *devinfo)
 >                  if (w != NULL)
 >                          w->connsenable[3] = 0;
 >                  break;
 > +       case HDA_CODEC_AD1984A:
 > +               w = hdaa_widget_get(devinfo, 7);
 > +               if (w != NULL)
 > +                       w->connsenable[0] = 0;
 > +               w = hdaa_widget_get(devinfo, 11);
 > +               if (w != NULL)
 > +                       w->connsenable[0] = 0;
 > +               break;
 >          case HDA_CODEC_AD1986A:
 >                  /*
 >                   * This CODEC has overcomplicated input mixing.
 >
 >
 
 Thanks, you patch just works fine, I hope you will find a universal 
 patch though.
 
 Cheers, and thank you :-)
 
 
 -- 
 David Demelier