bin/173725: portsnap(8) - fix entry validation

[J B]

The following reply was made to PR bin/173725; it has been noted by GNATS.

From: J B <jb.1234abcd at gmail.com>
To: bug-followup at FreeBSD.org, jb.1234abcd at gmail.com
Cc:  
Subject: Re: bin/173725: portsnap(8) - fix entry validation
Date: Wed, 21 Nov 2012 16:47:15 +0100

 It is not desirable to have a partially successful execution of an entry.
 If I were interested in partial outcomes, I would have requested:
 # portsnap fetch; portsnap update
 
 Check up front and reject entire entry:
 if update
   if no dir portsdir (e.g. /usr/ports), then reject entry
     PORTSDIR not configured or does not exist.
     You must run 'portsnap extract' before running 'portsnap update'.
 
 This advises the user to review and remedy the problem first, which is
 the right thing to do.