bin/163455: [ath] " bssid" in wlanN create_args does not change wlan MAC address

[Erick Wales]

The following reply was made to PR bin/163455; it has been noted by GNATS.

From: Erick Wales <wales.erick at gmail.com>
To: bug-followup at FreeBSD.org,
 john at jnielsen.net
Cc:  
Subject: Re: bin/163455: [ath] &quot;bssid&quot; in wlanN create_args does not change wlan MAC address
Date: Mon, 12 Mar 2012 21:17:42 -0700

 > The "bssid" parameter to ifconfig does notwork as advertised with ath
 > hardware: all wlan devices have the same MAC address(es) as their =
 parent(s),
 > whether or not the "bssid" keyword is used when they are created. I =
 know I
 > have used it successfully in the past but it may have been with a =
 different
 > (ath) card and I don't know what FreeBSD version it was so I can't be =
 much
 > help in determining when it stopped working (if indeed it ever did for =
 this
 > hardware). The machine in question currently has an AR9220 card:
 >=20
 > ath0: <Atheros 9220> mem 0xfebf0000-0xfebfffff irq 20 at device 5.0 on =
 pci4
 > [ath] enabling AN_TOP2_FIXUP
 > ath0: [HT] enabling HT modes
 > ath0: [HT] 2 RX streams; 2 TX streams
 > ath0: Enabling register serialisation
 > ath0: AR9220 mac 128.2 RF5133 phy 13.0
 >=20
 > ath0 at pci0:4:5:0:	class=3D0x028000 card=3D0x2096168c =
 chip=3D0x0029168c rev=3D0x01 hdr=3D0x00
 > vendor =3D 'Atheros Communications Inc.'
 > device =3D 'AR922X Wireless Network Adapter'
 
 Was looking for something to do today and looked into this. It appears =
 that the ath driver for the 9280 chipset (which is what your card has) =
 does not set the halBssIdMaskSupport capability. Since this variable is =
 not set the behavior you experience is to be expected. I'm not familiar =
 enough with the hardware to know for sure whether or not it supports =
 this feature but if it does I would imagine it would be as simple as =
 adding the following line to sys/dev/ath/ath_hal/ar9002/ar9280_attach.c:
 
 --- ar9280_attach.c	2012-01-02 20:26:54.000000000 -0700
 +++ ar9280_attach_new.c	2012-03-12 20:50:58.000000000 -0700
 @@ -841,6 +841,7 @@
  	pCap->halRxStbcSupport =3D 1;
  	pCap->halTxStbcSupport =3D 1;
  	pCap->halEnhancedDfsSupport =3D AH_TRUE;
 +	pCap->halBssIdMaskSupport =3D AH_TRUE;
 =20
  	return AH_TRUE;
  }
 
 If I'm way off base here someone let me know, this is my first dive into =
 these drivers.
 
 -Erick