bin/163775: [patch] sfxge(4) explitly sets -g -DDEBUG=1; infects kernel build with debug symbols

Garrett Cooper yanegomi at gmail.com
Mon Jan 2 11:20:09 UTC 2012


>Number:         163775
>Category:       bin
>Synopsis:       [patch] sfxge(4) explitly sets -g -DDEBUG=1; infects kernel build with debug symbols
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 02 11:20:09 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Garrett Cooper
>Release:        9.0-PRERELEASE
>Organization:
n/a
>Environment:
FreeBSD bayonetta.local 9.0-PRERELEASE FreeBSD 9.0-PRERELEASE #0 r229187M: Sun Jan  1 14:39:27 PST 2012     gcooper at bayonetta.local:/usr/obj/store/freebsd/stable/9/sys/BAYONETTA  amd64
>Description:
The attached patch removes the explicit setting of DEBUG_FLAGS in sfxge/Makefile, s.t. it doesn't affect developers such as myself who depend on DEBUG_FLAGS to be a user-defined value and thus react accordingly via make.conf.
>How-To-Repeat:
1. Add the following to make.conf:

.if defined(DEBUG_FLAGS) && !empty(DEBUG_FLAGS)
.error "I didn't do it!"
.endif

2. Run `make buildkernel'.
>Fix:


Patch attached with submission follows:

Index: sys/modules/sfxge/Makefile
===================================================================
--- sys/modules/sfxge/Makefile	(revision 229264)
+++ sys/modules/sfxge/Makefile	(working copy)
@@ -20,6 +20,4 @@
 SRCS+=	siena_mac.c siena_nic.c siena_nvram.c siena_phy.c
 SRCS+=	siena_sram.c siena_vpd.c 
 
-DEBUG_FLAGS= -g -DDEBUG=1
-
 .include <bsd.kmod.mk>


>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list