misc/165153: wrong de optimization

[Eugen Konkov]

>Number:         165153
>Category:       misc
>Synopsis:       wrong de optimization
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 14 20:30:10 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Eugen Konkov
>Release:        10.0-CURRENT
>Organization:
ISP FreeLine
>Environment:
>Description:
you must revert commit 231585 because of next:
there were
	/*
	 * Microoptimisations for a ng_socket with no
	 * hooks, or with a single hook, which is a
	 * common case.
	 */
which says that if node has no hooks DO NOTHING
	if (node->nd_numhooks == 0)
		return (NULL);

in r231585 there is no such check so for node with no hooks there were useless timespend in FOREACH loop. instead of fast 'return (NULL)' as it were before
>How-To-Repeat:

>Fix:
revert 231585 

>Release-Note:
>Audit-Trail:
>Unformatted: