misc/165153: wrong de optimization

Eugen Konkov kes-kes at yandex.ru
Tue Feb 14 20:30:11 UTC 2012

>Number:         165153
>Category:       misc
>Synopsis:       wrong de optimization
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 14 20:30:10 UTC 2012
>Originator:     Eugen Konkov
>Release:        10.0-CURRENT
ISP FreeLine
you must revert commit 231585 because of next:
there were
	 * Microoptimisations for a ng_socket with no
	 * hooks, or with a single hook, which is a
	 * common case.
which says that if node has no hooks DO NOTHING
	if (node->nd_numhooks == 0)
		return (NULL);

in r231585 there is no such check so for node with no hooks there were useless timespend in FOREACH loop. instead of fast 'return (NULL)' as it were before

revert 231585 


More information about the freebsd-bugs mailing list