kern/167001: [USB] [PATCH] add support for Smart G2 64MB memory key

[Daan Vreeken]

>Number:         167001
>Category:       kern
>Synopsis:       [USB] [PATCH] add support for Smart G2 64MB memory key
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 16 16:00:24 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Daan Vreeken
>Release:        FreeBSD 10-CURRENT amd64
>Organization:
Vitsch Electronics
>Environment:
System: FreeBSD Laptop72-13.Vitsch.lan 10.0-CURRENT FreeBSD 10.0-CURRENT #0: Sat Jan 28 21:31:14 CET 2012 root at RacebeestV4:/usr/src/sys/amd64/compile/Multimedia amd64


	
>Description:
Without this patch, the SmartG2 Memory key USB stick fails to attach with the
following in dmesg:

 ugen0.2: <SMART G2> at usbus0
 umass0: <SMART G2 Dell Memory Key, class 0/0, rev 2.00/0.01, addr 2> on usbus0
...
 (da0:umass-sim0:0:0:0): got CAM status 0x4
 (da0:umass-sim0:0:0:0): fatal error, failed to attach to device
 (da0:umass-sim0:0:0:0): lost device
 (da0:umass-sim0:0:0:0): removing device entry


	
>How-To-Repeat:
Insert a Smart G2 Memory key USB stick into a FreeBSD machine without the
following patch.

	
>Fix:
After applying the patch below, the stick will attach successfully with the
following dmesg output:

 ugen0.2: <SMART G2> at usbus0
 umass0: <SMART G2 Dell Memory Key, class 0/0, rev 2.00/0.01, addr 2> on usbus0
 da0 at umass-sim0 bus 0 scbus0 target 0 lun 0
 da0: <  > Removable Direct Access SCSI-2 device 
 da0: 1.000MB/s transfers
 da0: 61MB (125952 512 byte sectors: 64H 32S/T 61C)

	

In case the diff gets mangled in the mail, the diff can also be downloaded
from:
	http://www.vitsch.nl/pub_diffs/

Sponsored by: Vitsch Electronics

--- usb-smartg2-memkey64m-2012-04-16.diff begins here ---
Index: sys/dev/usb/quirk/usb_quirk.c
===================================================================
--- sys/dev/usb/quirk/usb_quirk.c	(revision 222928)
+++ sys/dev/usb/quirk/usb_quirk.c	(working copy)
@@ -454,6 +456,7 @@
 	USB_QUIRK(CHIPSBANK, USBMEMSTICK, 0x0000, 0xffff, UQ_MSC_NO_SYNC_CACHE),
 	USB_QUIRK(CHIPSBANK, USBMEMSTICK1, 0x0000, 0xffff, UQ_MSC_NO_SYNC_CACHE),
 	USB_QUIRK(NEWLINK, USB2IDEBRIDGE, 0x0000, 0xffff, UQ_MSC_NO_SYNC_CACHE),
+	USB_QUIRK(SMART_G2, MEMKEY64M, 0x0000, 0xffff, UQ_MSC_NO_INQUIRY),
 
 	/* Non-standard USB MIDI devices */
 	USB_QUIRK(ROLAND, UM1, 0x0000, 0xffff, UQ_AU_VENDOR_CLASS),
Index: sys/dev/usb/usbdevs
===================================================================
--- sys/dev/usb/usbdevs	(revision 222928)
+++ sys/dev/usb/usbdevs	(working copy)
@@ -718,6 +718,7 @@
 vendor MARVELL		0x9e88	Marvell Technology Group Ltd.
 vendor 3COM3		0xa727	3Com
 vendor DATAAPEX		0xdaae	DataApex
+vendor SMART_G2		0x0e39	Smart G2
 vendor HP2		0xf003	Hewlett Packard
 vendor USRP		0xfffe	GNU Radio USRP
 
@@ -3210,6 +3216,9 @@
 /* Teclast products */
 product TECLAST TLC300		0x3203	USB Media Player
 
+/* Smart G2 */
+product SMART_G2 MEMKEY64M	0x1700	Memory Key 64MB
+
 /* Supra products */
 product DIAMOND2 SUPRAEXPRESS56K 0x07da	Supra Express 56K modem
 product DIAMOND2 SUPRA2890	0x0b4a	SupraMax 2890 56K Modem
--- usb-smartg2-memkey64m-2012-04-16.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: