misc/161107: stop_boot in mountcritlocal usage is incorrect.

[Stephen Sanders]

>Number:         161107
>Category:       misc
>Synopsis:       stop_boot in mountcritlocal usage is incorrect.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 28 19:30:14 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Stephen Sanders
>Release:        8.1
>Organization:
OPNET
>Environment:
FreeBSD al3170ss.lab.opnet.com 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Fri Aug 19 11:48:26 PDT 2011     jtoung at focus8.networkphysics.com:/u1/builds/8.5.1/ALKernel.jt/src/sys/amd64/compile/NPBAB8  amd64

>Description:
The line "stop_boot true" in /etc/rc.d/mountcritlocal is incorrect.  checkvars will complain that $true not set correctly.

It should look more like:

STOP=true
stop_boot STOP


>How-To-Repeat:
Corrupt a local file system such that it will not mount ( some fun here ) and reboot the system.  When mountcritlocal tries to stop the start up, a message will be displayed stating that $true is invalid and one should check the man page for rc.conf



>Fix:
Change 

stop_boot true

to

STOP=true
stop_boot STOP

>Release-Note:
>Audit-Trail:
>Unformatted: