kern/161886: der_xx_oid not declared before use in gss_krb5.c

[Harry Coin]

>Number:         161886
>Category:       kern
>Synopsis:       der_xx_oid not declared before use in gss_krb5.c
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 21 17:20:10 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Harry Coin
>Release:        8Stable
>Organization:
Quiet Fountain LLC
>Environment:
amd64
>Description:


You will see many complaints by the compiler that der_get_oid der_free_oid der_length_oid and der_put_oid are implicitly defined in gss_krb5.c.  No check that the parameters in the call match what the procedure expects, nor are any decorations about the procedure's requirements taken into account.

>How-To-Repeat:
Do a make in /usr/src/kerberos5/lib/libgssapi_krb5, watch gss_krb5.c
>Fix:
Change the makefile:

INCS=	${KRB5DIR}/lib/gssapi/gssapi/gssapi_krb5.h
-INCSDIR= ${INCLUDEDIR}/gssapi
+INCSDIR= ${INCLUDEDIR}/gssapi ${KRB5DIR}/lib/asn1

SRCS=	8003.c \


..

Change gss_krb5.c
/* RCSID("$Id: gss_krb5.c 21889 2007-08-09 07:43:24Z lha $"); */

#include <krb5.h>
#include <roken.h>
+#include <der.h>



>Release-Note:
>Audit-Trail:
>Unformatted: