bin/143830: [patch] atmconfig(8): Fix conditional inclusion for sbin/atm/atmconfig

[Garrett Cooper]

The following reply was made to PR bin/143830; it has been noted by GNATS.

From: Garrett Cooper <yanegomi at gmail.com>
To: Garrett Cooper <yanegomi at gmail.com>
Cc: bug-followup at freebsd.org, gcooper at freebsd.org
Subject: Re: bin/143830: [patch] atmconfig(8): Fix conditional inclusion for
 sbin/atm/atmconfig
Date: Wed, 12 Oct 2011 16:15:30 -0700 (PDT)

   This message is in MIME format.  The first part should be readable text,
   while the remaining parts are likely unreadable without MIME-aware tools.
 
 --967339439-788255950-1318461338=:11533
 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
 
 On Wed, 12 Oct 2011, Garrett Cooper wrote:
 
 > Funny... hit the same problem again almost a year later in a different
 > portion of the tree:
 >
 > gensnmptree -e snmpMIB begemotSnmpdModuleTable begemotSnmpd
 > begemotTrapSinkTable  sysUpTime snmpTrapOID coldStart
 > authenticationFailure  begemotSnmpdTransUdp begemotSnmpdTransLsock
 > begemotSnmpdLocalPortTable  freeBSDVersion <
 > /build/home/gcooper/ix-projects/freenas/ix/FreeBSD/src/usr.sbin/bsnmpd/bsnmpd/../../../contrib/bsnmp/snmpd/tree.def
 >> oid.h
 > gensnmptree: not found
 > gensnmptree: not found
 > *** Error code 127
 > *** Error code 127
 > 2 errors
 > *** Error code 2
 > 1 error
 > *** Error code 2
 > 1 error
 > *** Error code 2
 >
 > No, I hadn't made any progress on this.
 >
 > The issue has unrooted itself on a freshly installed system without
 > bsnmpd support installed (the build image needs bsnmp support though),
 > so I think that it's safe to say that the problem really lies in the
 > fact that gensnmptree isn't treated properly like a tool and needs to
 > be shoved down into src/Makefile.inc1 .
 >
 > I'll work on whipping up a patch for this sometime this weekend.
 
 This should actually do it.
 -Garrett
 --967339439-788255950-1318461338=:11533
 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=add-missing-WITHOUT_BSNMP-logic.patch
 Content-Transfer-Encoding: BASE64
 Content-ID: <alpine.BSF.2.00.1110121615300.11533 at toaster.local>
 Content-Description: 
 Content-Disposition: attachment; filename=add-missing-WITHOUT_BSNMP-logic.patch
 
 SW5kZXg6IE1ha2VmaWxlLmluYzENCj09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0N
 Ci0tLSBNYWtlZmlsZS5pbmMxCShyZXZpc2lvbiAyMjYyNzIpDQorKysgTWFr
 ZWZpbGUuaW5jMQkod29ya2luZyBjb3B5KQ0KQEAgLTEwMTgsNyArMTAxOCw3
 IEBADQogX2F3az0JCXVzci5iaW4vYXdrDQogLmVuZGlmDQogDQotLmlmICR7
 Qk9PVFNUUkFQUElOR30gPCA3MDAwMTgNCisuaWYgJHtNS19CU05NUH0gIT0g
 Im5vIg0KIF9nZW5zbm1wdHJlZT0JdXNyLnNiaW4vYnNubXBkL2dlbnNubXB0
 cmVlDQogLmVuZGlmDQogDQpJbmRleDogc2Jpbi9hdG0vYXRtY29uZmlnL21h
 aW4uYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIHNiaW4vYXRtL2F0
 bWNvbmZpZy9tYWluLmMJKHJldmlzaW9uIDIyNjI3MikNCisrKyBzYmluL2F0
 bS9hdG1jb25maWcvbWFpbi5jCSh3b3JraW5nIGNvcHkpDQpAQCAtMzgsNyAr
 MzgsNyBAQA0KICNpbmNsdWRlIDxzdGRpbnQuaD4NCiAjaW5jbHVkZSA8Zm5t
 YXRjaC5oPg0KICNpbmNsdWRlIDxkaXJlbnQuaD4NCi0jaWZuZGVmIFJFU0NV
 RQ0KKyNpZiAhZGVmaW5lZChSRVNDVUUpICYmIGRlZmluZWQoV0lUSF9CU05N
 UCkNCiAjaW5jbHVkZSA8YnNubXAvYXNuMS5oPg0KICNpbmNsdWRlIDxic25t
 cC9zbm1wLmg+DQogI2luY2x1ZGUgPGJzbm1wL3NubXBjbGllbnQuaD4NCkBA
 IC00NDQsNyArNDQ0LDcgQEANCiAJZXhpdCgxKTsNCiB9DQogDQotI2lmbmRl
 ZiBSRVNDVUUNCisjaWYgIWRlZmluZWQoUkVTQ1VFKSAmJiBkZWZpbmVkKFdJ
 VEhfQlNOTVApDQogLyoNCiAgKiBQYXJzZSBhIHNlcnZlciBzcGVjaWZpY2F0
 aW9uDQogICoNCkBAIC01MjcsMTMgKzUyNywxMyBAQA0KIAlpbnQgb3B0LCBp
 Ow0KIAljb25zdCBzdHJ1Y3QgY21kdGFiICptYXRjaCwgKmNjLCAqdGFiOw0K
 IA0KLSNpZm5kZWYgUkVTQ1VFDQorI2lmICFkZWZpbmVkKFJFU0NVRSkgJiYg
 ZGVmaW5lZChXSVRIX0JTTk1QKQ0KIAlzbm1wX2NsaWVudF9pbml0KCZzbm1w
 X2NsaWVudCk7DQogCXNubXBfY2xpZW50LnRyYW5zID0gU05NUF9UUkFOU19M
 T0NfU1RSRUFNOw0KIAlzbm1wX2NsaWVudF9zZXRfaG9zdCgmc25tcF9jbGll
 bnQsIFBBVEhfSUxNSV9TT0NLKTsNCiAjZW5kaWYNCiANCi0jaWZkZWYgUkVT
 Q1VFDQorI2lmIGRlZmluZWQoUkVTQ1VFKSB8fCAhZGVmaW5lZChXSVRIX0JT
 Tk1QKQ0KICNkZWZpbmUgT1BUU1RSCSJodHYiDQogI2Vsc2UNCiAjZGVmaW5l
 CU9QVFNUUgkiaHR2czoiDQpAQCAtNTQ1LDcgKzU0NSw3IEBADQogCQkgIGNh
 c2UgJ2gnOg0KIAkJCWhlbHBfZnVuYygwLCBhcmd2KTsNCiANCi0jaWZuZGVm
 IFJFU0NVRQ0KKyNpZiAhZGVmaW5lZChSRVNDVUUpICYmIGRlZmluZWQoV0lU
 SF9CU05NUCkNCiAJCSAgY2FzZSAncyc6DQogCQkJcGFyc2Vfc2VydmVyKG9w
 dGFyZyk7DQogCQkJYnJlYWs7DQpAQCAtNTcwLDcgKzU3MCw3IEBADQogCQll
 cnIoMSwgTlVMTCk7DQogCW1lbWNweShtYWluX3RhYiwgc3RhdGljX21haW5f
 dGFiLCBzaXplb2Yoc3RhdGljX21haW5fdGFiKSk7DQogDQotI2lmbmRlZiBS
 RVNDVUUNCisjaWYgIWRlZmluZWQoUkVTQ1VFKSAmJiBkZWZpbmVkKFdJVEhf
 QlNOTVApDQogCS8qIFhYWCB3aGlsZSB0aGlzIGlzIGNvbXBpbGVkIGluICov
 DQogCWRldmljZV9yZWdpc3RlcigpOw0KICNlbmRpZg0KSW5kZXg6IHNiaW4v
 YXRtL2F0bWNvbmZpZy9NYWtlZmlsZQ0KPT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PQ0KLS0tIHNiaW4vYXRtL2F0bWNvbmZpZy9NYWtlZmlsZQkocmV2aXNpb24g
 MjI2MjcyKQ0KKysrIHNiaW4vYXRtL2F0bWNvbmZpZy9NYWtlZmlsZQkod29y
 a2luZyBjb3B5KQ0KQEAgLTUsMTIgKzUsMTYgQEANCiAjDQogIyAkRnJlZUJT
 RCQNCiANCisuaW5jbHVkZSA8YnNkLm93bi5taz4NCisNCiBQUk9HPQlhdG1j
 b25maWcNCi0uaWZuZGVmIFJFU0NVRQ0KKw0KKy5pZiAhZGVmaW5lZChSRVND
 VUUpICYmICR7TUtfQlNOTVB9ID09ICJ5ZXMiDQorQ0ZMQUdTCSs9IC1EV0lU
 SF9CU05NUA0KIFNSQ1M9CSR7Lk9CSkRJUn0vb2lkLmgNCiAuZW5kaWYNCiBT
 UkNTKz0JbWFpbi5jIGRpYWcuYyBuYXRtLmMNCi0uaWZuZGVmIFJFU0NVRQ0K
 Ky5pZiAhZGVmaW5lZChSRVNDVUUpICYmICR7TUtfQlNOTVB9ID09ICJ5ZXMi
 DQogU1JDUys9CWF0bWNvbmZpZ19kZXZpY2UuYw0KIC5lbmRpZg0KIE1BTj0J
 YXRtY29uZmlnLjgNCkBAIC0xOCwxNSArMjIsMTEgQEANCiANCiBDRkxBR1Mr
 PSAtSSR7Lk9CSkRJUn0NCiANCi0uaWZuZGVmIFJFU0NVRQ0KKy5pZiAhZGVm
 aW5lZChSRVNDVUUpICYmICR7TUtfQlNOTVB9ID09ICJ5ZXMiDQogRFBBREQ9
 CSR7TElCQlNOTVB9DQogTERBREQ9CS1sYnNubXANCiAuZW5kaWYNCiANCi0u
 aWZuZGVmIFJFU0NVRQ0KLUNMRUFORklMRVMrPSBvaWQuaA0KLS5lbmRpZg0K
 LQ0KICMgWFhYIC0gdGhpcyBpcyB2ZXJib3Rlbg0KIC5pZiAke01BQ0hJTkVf
 Q1BVQVJDSH0gPT0gImFybSINCiBXQVJOUz89IDMNCkBAIC0zOCw4ICszOCwx
 MCBAQA0KIFNOTVBfQVRNX0RFRj0gJHsuQ1VSRElSfS8uLi8uLi8uLi9jb250
 cmliL25nYXRtL3NubXBfYXRtL2F0bV90cmVlLmRlZglcDQogCSR7LkNVUkRJ
 Un0vLi4vLi4vLi4vdXNyLnNiaW4vYnNubXBkL21vZHVsZXMvc25tcF9hdG0v
 YXRtX2ZyZWVic2QuZGVmDQogDQorLmlmICR7TUtfQlNOTVB9ICE9ICJubyIN
 CiAkey5PQkpESVJ9L29pZC5oOiBhdG1fb2lkLmxpc3QgJHtTTk1QX0FUTV9E
 RUZ9DQotCWNhdCAke1NOTVBfQVRNX0RFRn0gfCBnZW5zbm1wdHJlZSAtZSBg
 dGFpbCAtbiArMiAkey5DVVJESVJ9L2F0bV9vaWQubGlzdGAgXA0KLQkJPiAk
 ey5PQkpESVJ9L29pZC5oDQorCWdlbnNubXB0cmVlIC1lIGB0YWlsIC1uICsy
 ICR7LkNVUkRJUn0vYXRtX29pZC5saXN0YCA8ICR7U05NUF9BVE1fREVGfSBc
 DQorCQk+ICR7LlRBUkdFVH0NCisuZW5kaWYNCiANCiAuaW5jbHVkZSA8YnNk
 LnByb2cubWs+DQo=
 
 --967339439-788255950-1318461338=:11533--