kern/162475: [ath] functions with return type HAL_BOOL (might) return HAL_STATUS

[Alexander Best]

>Number:         162475
>Category:       kern
>Synopsis:       [ath] functions with return type HAL_BOOL (might) return HAL_STATUS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 11 14:00:30 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Alexander Best
>Release:        10.0-CURRENT
>Organization:
>Environment:
FreeBSD otaku 10.0-CURRENT FreeBSD 10.0-CURRENT #0: Thu Nov 10 14:01:26 CET 2011     arundel at otaku:/usr/obj/usr/git-freebsd-head/sys/ARUNDEL  amd64
>Description:
in the following functions:

dev/ath/ath_hal/ar5416/ar5416_misc.c:ar5416SetDecompMask()
dev/ath/ath_hal/ar5212/ar5212_misc.c:ar5212SetDecompMask()

the return type is HAL_BOOL, yet it's possible that the return type is HAL_STATUS. Clang(1) complains about this via the -Wconversion warning.

cheers.
alex
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: