bin/162211: regression bug in calendar 8.2, 8-stable & current, OK in 8.1 & 7.4 & 6.4

[Julian H. Stacey]

>Number:         162211
>Category:       bin
>Synopsis:       regression bug in calendar 8.2, 8-stable & current, OK in 8.1 & 7.4 & 6.4
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 01 02:00:24 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Julian H. Stacey
>Release:        FreeBSD 8.2-RELEASE amd64
>Organization:
http://berklix.com BSD Linux Unix Consultancy, Munich/Muenchen.
>Environment:
System: FreeBSD fire.js.berklix.net 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Jun 2 23:10:13 CEST 2011 jhs at blak.js.berklix.net:/ad6s4/release/8.2-RELEASE/src/sys/amd64/compile/FIRE64.small amd64


	
>Description:
	User groups rely on calendar meeting dates such as
	1st Tuesday, 3rd Wednesday, Last Sunday each month.
	That broke in 8.2-RELEASE & 8-stable & current

>How-To-Repeat:
	
date # Tue Nov  1 .......
echo > ~/tmp/calendar_test_data << EOF
/* caution tabs in here so do not mouse copy */
Tuesday+1	first Tuesday in month
Wednesday	Midweek
Thursday-1	last Thursday in month
EOF

7.4 & 8.1-RELEASE: calendar -f ~/tmp/calendar_test_data
	Nov  1* first Tuesday in month
	Nov  2* Midweek

8.2-RELEASE & 8-stable & current
	Unprocessed:
	-------
	date: |Tuesday+1|
	flags: 10a - dayofweek modifierindex variable 
	modifierindex: |+1|
	dayofweek: |Tuesday| (2)
	Ignored: Tuesday+1      first Tuesday in month
	Unprocessed:
	-------
	date: |Thursday-1|
	flags: 10a - dayofweek modifierindex variable 
	modifierindex: |-1|
	dayofweek: |Thursday| (4)
	Ignored: Thursday-1     last Thursday in month
	Nov  2* Midweek

PS Some other good & bad patterns I tried :
/* 8.2	* /Friday	testtest	Result:		    Emits nothing*/
/* 8.2	* /Friday-1	testtest	Result:		    Emits nothing */
/* 8.2	* Friday	testtest	Result:		 OK Emits	*/
/* 8.2	* Friday-0	testtest	Result:		    Emits nothing*/
/* 8.2	* Friday-1	testtest	Result:		    Emits nothing*/
/* 8.2	* Friday-2	testtest	Result:		    Emits nothing*/
/* 8.2	*''/Friday	testtest	Result:		    Emits nothing*/
/* 8.2	*''/Friday+1	testtest	Result:		    Emits nothing*/
/* 8.2	*''/Friday-0	testtest	Result:		    Emits nothing*/
/* 8.2	*''/Friday-1	testtest	Result:		    Emits nothing*/
/* 8.2	2011/10/27	testtest	Result:		 OK Emits 	*/
/* 8.2	Friday		testtest	Result:		 OK Emits	*/
/* 8.2	Friday +1	testtest	Result:		    Emits nothing*/
/* 8.2	Friday+1	testtest	Result:		    Errors, and says Ignored*/
/* 6.4	Friday-1	testtest	Result:		 OK Emits         */
/* 8.2	Friday-1	testtest	Result:		    Errors, and says Ignored*/
/* 8.2	Oct Friday -1	testtest	Result:		    Emits nothing */
/* 8.2	Oct Friday-1	testtest	Result:		    Emits nothing*/

>Fix:
	
	http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.bin/calendar/calendar.c
	shows edwin@ was last person interested in calendar.c 
	Mon Aug 23 22:09:25 2010 UTC
		...
		r205821:
		Long awaited update to the calendar system:
		- Repeating events
		...
	so FYI cc'd him as he's hopefully familiar with sources.
>Release-Note:
>Audit-Trail:
>Unformatted: