misc/157118: cleanup error in IGB driver - igb_setup_receive_structures()

[Aaron Styx]

>Number:         157118
>Category:       misc
>Synopsis:       cleanup error in IGB driver - igb_setup_receive_structures()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 17 13:10:11 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Aaron Styx
>Release:        7.4
>Organization:
BAE Systems
>Environment:
all
>Description:
IGB driver version 2.0.7. I'm working from the release version of FreeBSD v7.4. 

I'm not entirely sure what would be correct here, but in the function igb_setup_receive_structures() in the e1000 igb driver (if_igb.c), the fail condition looks wrong. At first glance, it looks like rxr should get rx_rings[j], not [i]. Also, that code will never be run since the condition on the for loop is j > i, i will be >= zero, and j starts at zero.  

-STX
>How-To-Repeat:
I have not hit this code on a running system; just looked suspicious. 
>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: