bin/157732: commit references a PR

dfilter service dfilter at FreeBSD.ORG
Wed Jun 29 16:50:07 UTC 2011

The following reply was made to PR bin/157732; it has been noted by GNATS.

From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at
Subject: Re: bin/157732: commit references a PR
Date: Wed, 29 Jun 2011 16:44:04 +0000 (UTC)

 Author: dim
 Date: Wed Jun 29 16:43:44 2011
 New Revision: 223678
   MFC r223579:
   For some reason, contrib/traceroute/traceroute.c ensures MAXHOSTNAMELEN
   is defined, but then proceeds to use a hardcoded maximum hostname length
   of 64 anyway.  Fix this by checking against MAXHOSTNAMELEN instead.
   PR:	bin/157732
 Directory Properties:
   stable/8/contrib/traceroute/   (props changed)
 Modified: stable/8/contrib/traceroute/traceroute.c
 --- stable/8/contrib/traceroute/traceroute.c	Wed Jun 29 16:40:41 2011	(r223677)
 +++ stable/8/contrib/traceroute/traceroute.c	Wed Jun 29 16:43:44 2011	(r223678)
 @@ -1625,7 +1625,7 @@ gethostinfo(register char *hostname)
  	register char **p;
  	register u_int32_t addr, *ap;
 -	if (strlen(hostname) > 64) {
 +	if (strlen(hostname) >= MAXHOSTNAMELEN) {
  		Fprintf(stderr, "%s: hostname \"%.32s...\" is too long\n",
  		    prog, hostname);
 svn-src-all at mailing list
 To unsubscribe, send any mail to "svn-src-all-unsubscribe at"

More information about the freebsd-bugs mailing list