bin/157732: commit references a PR

dfilter service dfilter at FreeBSD.ORG
Sun Jun 26 19:10:03 UTC 2011


The following reply was made to PR bin/157732; it has been noted by GNATS.

From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: bin/157732: commit references a PR
Date: Sun, 26 Jun 2011 19:03:48 +0000 (UTC)

 Author: dim
 Date: Sun Jun 26 19:03:33 2011
 New Revision: 223579
 URL: http://svn.freebsd.org/changeset/base/223579
 
 Log:
   For some reason, contrib/traceroute/traceroute.c ensures MAXHOSTNAMELEN
   is defined, but then proceeds to use a hardcoded maximum hostname length
   of 64 anyway.  Fix this by checking against MAXHOSTNAMELEN instead.
   
   PR:		bin/157732
   MFC after:	3 days
 
 Modified:
   head/contrib/traceroute/traceroute.c
 
 Modified: head/contrib/traceroute/traceroute.c
 ==============================================================================
 --- head/contrib/traceroute/traceroute.c	Sun Jun 26 19:02:34 2011	(r223578)
 +++ head/contrib/traceroute/traceroute.c	Sun Jun 26 19:03:33 2011	(r223579)
 @@ -1618,7 +1618,7 @@ gethostinfo(register char *hostname)
  	register char **p;
  	register u_int32_t addr, *ap;
  
 -	if (strlen(hostname) > 64) {
 +	if (strlen(hostname) >= MAXHOSTNAMELEN) {
  		Fprintf(stderr, "%s: hostname \"%.32s...\" is too long\n",
  		    prog, hostname);
  		exit(1);
 _______________________________________________
 svn-src-all at freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"
 


More information about the freebsd-bugs mailing list