misc/157540: [patch] make dmidecode an optional dependency for sysutils/flashrom

[Mark Johnston]

>Number:         157540
>Category:       misc
>Synopsis:       [patch] make dmidecode an optional dependency for sysutils/flashrom
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 02 19:40:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Mark Johnston
>Release:        8-STABLE
>Organization:
>Environment:
FreeBSD oddish.mark-home 8.2-STABLE FreeBSD 8.2-STABLE #0: Mon May 16 18:43:29 EDT 2011     root at oddish.mark-home:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
flashrom will make use of dmidecode to gather DMI info if it is present. However, it is not required in order to use flashrom, and flashrom will continue if it can't find dmidecode on the system.
>How-To-Repeat:

>Fix:
I've been using flashrom-0.9.3 without dmidecode on a test machine. I attached a patch which adds an option (default yes) to install dmidecode as a dependency.

Patch attached with submission follows:

diff --git a/Makefile b/Makefile
index 2c73c5f..0be40ac 100644
--- a/Makefile
+++ b/Makefile
@@ -14,9 +14,9 @@ MAINTAINER=	avl at FreeBSD.org
 COMMENT=	A utility for reading, writing, verifying and erasing flash ROM chips
 
 LIB_DEPENDS=	pci.3:${PORTSDIR}/devel/libpci
-RUN_DEPENDS=	dmidecode:${PORTSDIR}/sysutils/dmidecode
 
-OPTIONS=	FTDI	"Enable external FT2232SPI flasher support"	off
+OPTIONS=	FTDI		"Enable external FT2232SPI flasher support"	off \
+		DMIDECODE	"Use dmidecode to gather DMI information"	on
 
 USE_BZIP2=	yes
 USE_GMAKE=	yes
@@ -39,6 +39,9 @@ MAN8=		${PORTNAME}.8
 USE_GNOME=	pkgconfig
 LIB_DEPENDS+=	ftdi.18:${PORTSDIR}/devel/libftdi
 .endif
+.if defined(WITH_DMIDECODE)
+RUN_DEPENDS=	dmidecode:${PORTSDIR}/sysutils/dmidecode
+.endif
 
 post-patch:
 .if defined(WITH_FTDI)


>Release-Note:
>Audit-Trail:
>Unformatted: