bin/158819: [patch] improve top(1)'s message for the interactive 'C' option

Alexander Best arundel at
Mon Jul 11 23:20:09 UTC 2011

>Number:         158819
>Category:       bin
>Synopsis:       [patch] improve top(1)'s message for the interactive 'C' option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 11 23:20:08 UTC 2011
>Originator:     Alexander Best
>Release:        9.0-CURRENT
FreeBSD otaku 9.0-CURRENT FreeBSD 9.0-CURRENT #23 r223911=11f0313-dirty: Mon Jul 11 00:20:49 CEST 2011     arundel at otaku:/usr/obj/usr/git-freebsd-head/sys/ARUNDEL  amd64
when switching between weighted and raw cpu mode via the interactive 'C' key, top only displays the following messsage:

"Displaying CPU" or "Displaying WCPU"

that's not really a grand description, is it? the attached patch improves the message imho.
apply the attached patch!

Patch attached with submission follows:

diff --git a/contrib/top/top.c b/contrib/top/top.c
index 4e4d86d..01c5946 100644
--- a/contrib/top/top.c
+++ b/contrib/top/top.c
@@ -1029,8 +1029,8 @@ restart:
 			    case CMD_wcputog:
 				ps.wcpu = !ps.wcpu;
 				new_message(MT_standout | MT_delayed,
-				    " Displaying %sCPU",
-				    ps.wcpu ? "W" : "");
+				    " Displaying %s CPU usage.",
+				    ps.wcpu ? "weighted" : "raw");
 				header_text = format_header(uname_field);


More information about the freebsd-bugs mailing list