misc/158636: if_pfsync.c fails to build when NBPFILTER == 0

[Robert Millan]

>Number:         158636
>Category:       misc
>Synopsis:       if_pfsync.c fails to build when NBPFILTER == 0
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 04 14:10:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Robert Millan
>Release:        Debian GNU/kFreeBSD "sid"
>Organization:
>Environment:
>Description:

if_pfsync.c fails to build when NBPFILTER == 0.  It seems that variable 'm' in pfsync_sendout() is only declared when NBPFILTER > 0, but later it is used unconditionally.

gcc-4.6 -c -O -pipe  -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign   -Wmissing-include-dirs -fdiagnostics-show-option -nostdinc  -I. -I../../.. -I../../../contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=10000 --param large-function-growth=100000 --param max-inline-insns-single=10000  -fno-pic -mno-abicalls -G0 -march=mips32 -mabi=32 -D__mips_o32 -msoft-float -ffreestanding   ../../../contrib/pf/net/if_pfsync.c -I../../../contrib/pf
In file included from ../../../net/if_var.h:82:0,
                 from ../../../net/if.h:472,
                 from ../../../contrib/pf/net/if_pfsync.c:102:
./../../sys/buf_ring.h: In function 'buf_ring_dequeue_sc':
./../../sys/buf_ring.h:189:33: warning: variable 'cons_next_next' set but not used [-Wunused-but-set-variable]
./../../contrib/pf/net/if_pfsync.c: In function 'pfsync_sendout':
./../../contrib/pf/net/if_pfsync.c:2163:2: error: 'm' undeclared (first use in this function)
./../../contrib/pf/net/if_pfsync.c:2163:2: note: each undeclared identifier is reported only once for each function it appears in
*** Error code 1

Full build log available in:

https://buildd.debian.org/status/fetch.php?pkg=kfreebsd-9&arch=mipsel&ver=9.0~svn223728-1&stamp=1309717094

>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: