misc/143831: [bsd.own.mk] [patch] Fix missing atm -> bsnmp dependency

[Bjoern A. Zeeb]

The following reply was made to PR misc/143831; it has been noted by GNATS.

From: "Bjoern A. Zeeb" <bz at FreeBSD.org>
To: bug-followup at FreeBSD.org, gcooper at FreeBSD.org
Cc: miwi at FreeBSD.org
Subject: Re: misc/143831: [bsd.own.mk] [patch] Fix missing atm -> bsnmp
 dependency
Date: Mon, 21 Feb 2011 18:46:20 +0000 (UTC)

 Hi,
 
 I think the patch is too excessive, as is the following in bsd.own.mk:
 
 .if ${MK_NETGRAPH} == "no"
 MK_ATM:=        no
 MK_BLUETOOTH:=  no
 .endif
 
 To my understanding disabling all of atm if we don't have netgraph
 seems wrong but probably was an easy path at some point.
 
 Without testing I think the following patch should be enough:
 
 Index: rescue/rescue/Makefile
 ===================================================================
 --- rescue/rescue/Makefile      (revision 218757)
 +++ rescue/rescue/Makefile      (working copy)
 @@ -99,7 +99,7 @@ CRUNCH_PROGS_sbin= atacontrol badsect                         \
          restore rcorder route routed rtquery rtsol savecore     \
          spppcontrol swapon sysctl tunefs umount
 
 -.if ${MK_ATM} != "no"
 +.if ${MK_ATM} != "no" && ${MK_BSNMP} != "no"
   CRUNCH_PROGS_sbin+= atmconfig
   .endif
 
 Index: sbin/Makefile
 ===================================================================
 --- sbin/Makefile       (revision 218757)
 +++ sbin/Makefile       (working copy)
 @@ -73,7 +73,7 @@ SUBDIR=adjkerntz \
          tunefs \
          umount \
 
 -.if ${MK_ATM} != "no"
 +.if ${MK_ATM} != "no" && ${MK_BSNMP} != "no"
   SUBDIR+=       atm
   .endif
 
 
 BTw, the test case of `make -C sbin/atm WITHOUT_BSNMP=yes depend`
 seems wrong as well as that actually ignores some checks in place.
 
 /bz
 
 -- 
 Bjoern A. Zeeb                                 You have to have visions!
           Stop bit received. Insert coin for new address family.