bin/163053: [fix] 'camcontrol nego -D' is ignored

Peter pmc at citylink.dinoex.sub.org
Sun Dec 4 10:13:57 UTC 2011


>Number:         163053
>Category:       bin
>Synopsis:       [fix] 'camcontrol nego -D' is ignored
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 04 10:13:56 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Peter Much
>Release:        FreeBSD 7.4-STABLE i386
>Organization:
n/a
>Environment:
System: FreeBSD disp.oper.dinoex.org 7.4-STABLE FreeBSD 7.4-STABLE #14: Sat Dec 3 20:55:11 CET 2011 root at disp.oper.dinoex.org:/usr/src/sys/i386/compile/D1R74V1 i386

	Seems to be present in Current, too.

>Description:

	The "-D" option to "camcontrol nego" has no actual effect,
	except when applied together with some other option. 

	This is obvious from the (missing) code.

>How-To-Repeat:

	just try it out.

>Fix:

*** sbin/camcontrol/camcontrol.c.orig	Sun Dec  4 03:06:01 2011
--- sbin/camcontrol/camcontrol.c	Sun Dec  4 03:07:01 2011
***************
*** 2734,2739 ****
--- 2734,2740 ----
  				spi->flags &= ~CTS_SPI_FLAGS_DISC_ENB;
  			else
  				spi->flags |= CTS_SPI_FLAGS_DISC_ENB;
+ 			didsettings++;
  		}
  
  		if (scsi && tag_enable != -1) {
>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-bugs mailing list